crueber/walhub
Watch
1
0
Fork
You've already forked walhub
 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity

Fix #96: private-IP range gaps #105

Merged
crueber merged 2 commits from fix/issue-96 into main 2026-09-05 03:24:46 +00:00
Conversation 0 Commits 2 Files changed 4 +38 -29
crueber commented 2026-09-05 03:21:15 +00:00
Owner
Copy link

Fixes #96. Verdict: the gap was REAL — PR #88's shared internal/egress table covered 198.18.0.0/15 + TEST-NET-1/2/3 (+ mapped-v6), but internal/repoimport/url.go:isPrivateIP kept its own hand-rolled list and never delegated to it. Fix: isPrivateIP now denies loopback explicitly (egress allows it for dev webhooks; import sources must never resolve inward) and defers everything else to egress.BlockedIP; unparseable input fails closed. Table tests extended in both packages (incl. mapped-v6 forms for all four listed ranges); docs/features/10 SSRF paragraph + Decisions updated in the same change. Evidence: go test -race green for both packages; cover repoimport 95.7%, egress 97.6%.

Fixes #96. Verdict: the gap was REAL — PR #88's shared internal/egress table covered 198.18.0.0/15 + TEST-NET-1/2/3 (+ mapped-v6), but internal/repoimport/url.go:isPrivateIP kept its own hand-rolled list and never delegated to it. Fix: isPrivateIP now denies loopback explicitly (egress allows it for dev webhooks; import sources must never resolve inward) and defers everything else to egress.BlockedIP; unparseable input fails closed. Table tests extended in both packages (incl. mapped-v6 forms for all four listed ranges); docs/features/10 SSRF paragraph + Decisions updated in the same change. Evidence: go test -race green for both packages; cover repoimport 95.7%, egress 97.6%.
internal/repoimport/url.go kept its own range list and missed
198.18.0.0/15, 192.0.2.0/24, 198.51.100.0/24, 203.0.113.0/24 (plus
240.0.0.0/4, ::/128, 2001:db8::/32). PR #88's internal/egress table
covered them, but url.go never used it. isPrivateIP now denies
loopback explicitly (egress allows it for dev webhooks; import
sources must never resolve inward) and defers the rest to
egress.BlockedIP; unparseable input fails closed. Table tests
extended in both packages; doc 10 SSRF paragraph + Decisions
updated in the same change.
checkPrivate still carried the pre-delegation range enumeration;
point it at isPrivateIP/shared table. Pin unparseable input
(net.ParseIP nil) failing closed in TestIsPrivateIPShapes.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
actions

   
bug
Something is not working

  
cli

   
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
fork

   
forum

   
git storage

   
help wanted
Need some help

  
insights

   
invalid
Something is wrong

  
issues

   
moderation

   
oidc

   
ownership transfer

   
packages

   
pr/merge protection rules

   
projects

   
pull requests

   
question
More information is needed

  
releases

   
sponsorships

   
tags

   
webhooks

   
wiki

   
wontfix
This won't be fixed

No labels
actions
bug
cli
duplicate
enhancement
fork
forum
git storage
help wanted
insights
invalid
issues
moderation
oidc
ownership transfer
packages
pr/merge protection rules
projects
pull requests
question
releases
sponsorships
tags
webhooks
wiki
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
crueber/walhub!105
No description provided.