In the clone dropdown it uses the wrong protocol #124

New issue

Closed

opened 2026-09-05 05:30:21 +00:00 by crueber · 3 comments

crueber commented

2026-09-05 05:30:21 +00:00

Owner

It shows "https" in the menu pill, but the actual text says http. It should say https.

Remove the "git" and the little container below that too. Those are artifacts of the first attempt.

![image](/attachments/705998c8-4821-4ed4-87fc-b6c92a6bd3cc) It shows "https" in the menu pill, but the actual text says http. It should say https. Remove the "git" and the little container below that too. Those are artifacts of the first attempt.

image.png

31 KiB

crueber referenced this issue from a commit

2026-09-05 08:14:46 +00:00

Fix #124: clone menu protocol honesty + artifact removal (12_web_ui.md)

crueber referenced this issue from a pull request that will close it,

2026-09-05 08:14:48 +00:00

Fix #124: clone menu protocol honesty + artifact removal #131

crueber commented

2026-09-05 08:14:55 +00:00

Author

Owner

Fixed by #131 — pill label now derives from the advertised clone_url scheme (HTTP vs HTTPS) so pill and text agree, URL shown verbatim so the command works; dead git block removed. Verified in real Chromium (both toggles, dark+light, zero console errors) and node --test 295/295.

Fixed by https://git.packden.us/crueber/walhub/pulls/131 — pill label now derives from the advertised clone_url scheme (HTTP vs HTTPS) so pill and text agree, URL shown verbatim so the command works; dead git block removed. Verified in real Chromium (both toggles, dark+light, zero console errors) and node --test 295/295.

crueber commented

2026-09-05 08:16:45 +00:00

Author

Owner

PR #131 review (fix/issue-124, e3cf334) — APPROVED, ready to merge.

Honesty rule sound: pill derives from the advertised scheme (web/src/lib/clone.js:28-30 httpProtoLabel: HTTPS only for /^https:/i, else HTTP) and the text shows summary.clone_url verbatim (web/src/pages/Repo.jsx:74-77). Pill and text agree by construction in both modes (http->label+verbatim URL; ssh->SSH+ssh://, derivation unchanged). Command works because the verbatim URL is what the server advertised. Proxy case: http-behind-TLS-proxy still shows HTTP + http:// URL, which works via the proxy 301 — honest, not misleading; X-Forwarded-Proto follow-up is noted in the doc entry, correctly scoped out.

No upgrade-to-https breakage: nothing upgrades http->https for display; LAN plain-http stays working.

Dead block fully removed: trailing

git + duplicated cmd textbox is gone; only the legit per-recipe loop remains (Repo.jsx:139-150). No dead CSS: .clone-body solid panel (ui.css:113) still live, recipe/cmd classes are inline Tailwind still in use.

SSH toggle unaffected and correct: sshCloneUrl unchanged (host reuse, HTTP port dropped); existing ssh tests untouched and passing.

Tests pin agreement: web/test/unit/clone.test.js:21-29 covers https/HTTPS->HTTPS, http/LAN/garbage/null/undefined->HTTP. No new deps (4 files: clone.js, Repo.jsx, clone.test.js, 12_web_ui.md). Dark+light: no theme classes changed; solid panel + dark: variants intact. Doc note accurate (decision (a), rejection rationale with live verification, follow-up scoped).

Verify (scratch worktree /tmp/opencode/pr131 @ e3cf334): node --test web/test/unit/*.test.js 295/295 pass (first run showed 2 fails from missing node_modules in the fresh worktree — env gap, resolved by symlinking main web/node_modules, unrelated to PR); clone.test.js 9/9; vite build clean (116 modules). No browser per task instructions (node tests + reasoning). BEFORE screenshot confirms the reported mismatch (HTTPS pill vs http:// text + duplicated git block).

No fixes pushed — nothing to fix. MERGE RECOMMENDATION: ready to merge.

PR #131 review (fix/issue-124, e3cf334) — APPROVED, ready to merge. Honesty rule sound: pill derives from the advertised scheme (web/src/lib/clone.js:28-30 httpProtoLabel: HTTPS only for /^https:/i, else HTTP) and the text shows summary.clone_url verbatim (web/src/pages/Repo.jsx:74-77). Pill and text agree by construction in both modes (http->label+verbatim URL; ssh->SSH+ssh://, derivation unchanged). Command works because the verbatim URL is what the server advertised. Proxy case: http-behind-TLS-proxy still shows HTTP + http:// URL, which works via the proxy 301 — honest, not misleading; X-Forwarded-Proto follow-up is noted in the doc entry, correctly scoped out. No upgrade-to-https breakage: nothing upgrades http->https for display; LAN plain-http stays working. Dead block fully removed: trailing <div class=clone-recipe><strong>git</strong> + duplicated cmd textbox is gone; only the legit per-recipe loop remains (Repo.jsx:139-150). No dead CSS: .clone-body solid panel (ui.css:113) still live, recipe/cmd classes are inline Tailwind still in use. SSH toggle unaffected and correct: sshCloneUrl unchanged (host reuse, HTTP port dropped); existing ssh tests untouched and passing. Tests pin agreement: web/test/unit/clone.test.js:21-29 covers https/HTTPS->HTTPS, http/LAN/garbage/null/undefined->HTTP. No new deps (4 files: clone.js, Repo.jsx, clone.test.js, 12_web_ui.md). Dark+light: no theme classes changed; solid panel + dark: variants intact. Doc note accurate (decision (a), rejection rationale with live verification, follow-up scoped). Verify (scratch worktree /tmp/opencode/pr131 @ e3cf334): node --test web/test/unit/*.test.js 295/295 pass (first run showed 2 fails from missing node_modules in the fresh worktree — env gap, resolved by symlinking main web/node_modules, unrelated to PR); clone.test.js 9/9; vite build clean (116 modules). No browser per task instructions (node tests + reasoning). BEFORE screenshot confirms the reported mismatch (HTTPS pill vs http:// text + duplicated git block). No fixes pushed — nothing to fix. MERGE RECOMMENDATION: ready to merge.

crueber closed this issue

2026-09-05 08:17:04 +00:00

crueber referenced this issue from a commit

2026-09-05 08:17:04 +00:00

Merge pull request 'Fix #124: clone menu protocol honesty + artifact removal' (#131) from fix/issue-124 into main

crueber commented

2026-09-05 08:17:04 +00:00

Author

Owner

Fixed by PR #131 (review: honesty-by-construction verified, dead block gone; 295/295 node tests), merged. Closing.

crueber referenced this issue

2026-09-05 23:29:53 +00:00