Fix #236: opaque branch picker dropdowns #245

Merged

crueber merged 1 commit from fix/issue-236 into main

2026-09-09 18:11:50 +00:00

crueber commented

2026-09-09 17:41:21 +00:00

Owner

Fixes #236. The PullNew head/base pickers and the Pull reviewer picker rendered their option list with bare ref-list/ref-item classes, which have no rules in the shipped web/src/ui.css (web/css/repo.css is dead — only src/ui.css is imported) — so page text bled through the open dropdown. The #115 shared opaque-popover rule covers ref-drop but these two dropdowns missed that sweep, so this wires it up with zero new CSS (same ref-drop card pattern as the Repo.jsx picker) and gives the rows the shared hover-highlight utilities. Dark + light.

Verification:

New web/test/unit/pull-dropdown-opaque.test.js (5 tests: opaque panel wiring + row highlight both themes for both pickers, behavior unchanged).
Full suite: node --test web/test/unit/*.test.js → 460/460 pass (455 baseline + 5 new).
vite build + SDK bundle clean; compiled CSS confirms .ref-drop solid-bg override sorts after .card and both hover utilities exist.
Browser: not driven — shared daemon blocks loopback per task rules; cascade verified statically in compiled output instead.

No new deps. No doc change (no behavior contract changed, markup-only fix reusing frozen #115 classes).

Fixes #236. The PullNew head/base pickers and the Pull reviewer picker rendered their option list with bare `ref-list`/`ref-item` classes, which have no rules in the shipped `web/src/ui.css` (`web/css/repo.css` is dead — only `src/ui.css` is imported) — so page text bled through the open dropdown. The #115 shared opaque-popover rule covers `ref-drop` but these two dropdowns missed that sweep, so this wires it up with zero new CSS (same `ref-drop card` pattern as the Repo.jsx picker) and gives the rows the shared hover-highlight utilities. Dark + light. Verification: - New `web/test/unit/pull-dropdown-opaque.test.js` (5 tests: opaque panel wiring + row highlight both themes for both pickers, behavior unchanged). - Full suite: `node --test web/test/unit/*.test.js` → 460/460 pass (455 baseline + 5 new). - `vite build` + SDK bundle clean; compiled CSS confirms `.ref-drop` solid-bg override sorts after `.card` and both hover utilities exist. - Browser: not driven — shared daemon blocks loopback per task rules; cascade verified statically in compiled output instead. No new deps. No doc change (no behavior contract changed, markup-only fix reusing frozen #115 classes).

crueber added 1 commit

2026-09-09 17:41:22 +00:00

Fix #236 : opaque branch/reviewer picker dropdowns via shared popover classes 51a62209df

PullNew head/base and Pull reviewer dropdowns used bare .ref-list /
.ref-item, which have no rules in the shipped web/src/ui.css (web/css/
repo.css is dead), so page text bled through the open picker. Wire the
#115 shared opaque-popover classes (ref-drop card, same pattern as the
Repo.jsx picker) onto both dropdowns and give rows the shared hover
utilities — no new CSS, dark + light. Adds pull-dropdown-opaque.test.js.

crueber referenced this pull request

2026-09-09 17:41:24 +00:00

Pull-new branch dropdown is transparent: page text shows through under the options #236

crueber referenced this pull request

2026-09-09 17:42:57 +00:00

Housekeeping: delete merged remote branches (117 of 119 heads are fully merged into main) and prune local clones #246

crueber referenced this pull request

2026-09-09 18:10:46 +00:00

Pull-new branch dropdown is transparent: page text shows through under the options #236

crueber merged commit cb6738e35f into main

2026-09-09 18:11:50 +00:00

crueber referenced this pull request from a commit