Fix #253: create tag from UI #262

Merged

crueber merged 2 commits from fix/issue-253 into main

2026-09-10 01:06:26 +00:00

crueber commented

2026-09-10 00:32:47 +00:00

Owner

Fixes #253: create a lightweight tag at a given commit from the commit-view UI, server-side via the WAL ref-update path.

What: new internal/tags package + POST /{o}/{r}/api/tags (both lanes, Seam 1) publishing one EntryKindRefUpdate CAS-create — no new WAL kind. Commit.jsx gains a write-gated Create-tag affordance; SDK gains repo.tagsApi.create; create tag → create release now works end to end.

Design call (documented in docs/go/14_extensibility.md Decisions): lightweight-only v1 (recommended option (a)/(c)) — annotated (non-empty message) → 422, never a silent downgrade; object-write path under frozen proto rules is the follow-up. P6 = RoleWrite (push-equivalent) + explicit policy EvaluateProtect create-check (pull-merge precedent). Validation: git refname rules (400), sha must resolve (404), existing tag → 409 via publish verify (race-safe). Events ride the existing WAL bridge identically to pushed tags.

Tests: internal/tags 98.4% statements (go test -race clean); table-driven httptest (201/400/404/409/422/401/403/405); real-git CommitExists tests; end-to-end through a real WAL registry (cmd/walhub: create → sync-visible → 409 → restart-replay from wiped cache); SDK surface tests (node --test); releases/events/policy suites green; gofmt/vet clean.

Deviations/notes: no browser drive (per task note — shared daemon blocks loopback); full node --test shows 7 pre-existing failures from missing node_modules (solid-js/marked) in this env, unrelated files; make e2e/sim not run (no wal/git-path changes — new package reuses the existing publish funnel); .gitignore re-includes internal/tags/ against blanket ctags tags ignores.

Fixes #253: create a lightweight tag at a given commit from the commit-view UI, server-side via the WAL ref-update path. **What:** new `internal/tags` package + `POST /{o}/{r}/api/tags` (both lanes, Seam 1) publishing one `EntryKindRefUpdate` CAS-create — no new WAL kind. Commit.jsx gains a write-gated Create-tag affordance; SDK gains `repo.tagsApi.create`; create tag → create release now works end to end. **Design call (documented in docs/go/14_extensibility.md Decisions):** lightweight-only v1 (recommended option (a)/(c)) — annotated (non-empty message) → 422, never a silent downgrade; object-write path under frozen proto rules is the follow-up. P6 = RoleWrite (push-equivalent) + explicit policy EvaluateProtect create-check (pull-merge precedent). Validation: git refname rules (400), sha must resolve (404), existing tag → 409 via publish verify (race-safe). Events ride the existing WAL bridge identically to pushed tags. **Tests:** `internal/tags` 98.4% statements (`go test -race` clean); table-driven httptest (201/400/404/409/422/401/403/405); real-git CommitExists tests; end-to-end through a real WAL registry (`cmd/walhub`: create → sync-visible → 409 → restart-replay from wiped cache); SDK surface tests (`node --test`); releases/events/policy suites green; gofmt/vet clean. **Deviations/notes:** no browser drive (per task note — shared daemon blocks loopback); full `node --test` shows 7 pre-existing failures from missing `node_modules` (solid-js/marked) in this env, unrelated files; `make e2e/sim` not run (no wal/git-path changes — new package reuses the existing publish funnel); `.gitignore` re-includes `internal/tags/` against blanket ctags `tags` ignores.

crueber added 1 commit

2026-09-10 00:32:48 +00:00

Fix #253 : create lightweight tag from UI via WAL ref-update path a938607427

New internal/tags package (docs/go/14_extensibility.md Decisions):
POST /{o}/{r}/api/tags (+ api-browser twin, Seam 1) publishes one
EntryKindRefUpdate CAS-create; no new WAL kind. Lightweight-only v1:
non-empty message -> 422 (annotated needs a tag object the frozen
proto cannot carry; follow-up). P6 RoleWrite + policy EvaluateProtect
(principal, refs/tags/<name>, create); git refname validation (400),
sha must resolve (404), existing tag 409 via publish verify. Events
ride the existing WAL bridge unchanged. UI: Create-tag affordance on
Commit.jsx (write-gated) + SDK repo.tagsApi.create. Also re-includes
internal/tags/ against blanket ctags ignores.

crueber referenced this pull request

2026-09-10 00:32:51 +00:00

Create a tag at a given commit from the UI (commit view action), server-side via the WAL ref-update path #253

crueber added 1 commit

2026-09-10 01:04:58 +00:00

Fix #253 : import reportError in Commit.jsx create-tag form 78413696e2

The CreateTag submit handler calls reportError(err, "create-tag") on
failure but the data.js import lacked the name — a ReferenceError that
masked the real server error. Same import shape as Access/Issue pages.

crueber referenced this pull request

2026-09-10 01:04:59 +00:00

Annotated tag creation from the UI (follow-up to #253) #263

crueber referenced this pull request

2026-09-10 01:05:13 +00:00

Create a tag at a given commit from the UI (commit view action), server-side via the WAL ref-update path #253

crueber merged commit 58e56c7f18 into main

2026-09-10 01:06:26 +00:00

crueber referenced this pull request from a commit

2026-09-10 01:06:27 +00:00

Merge pull request 'Fix #253: create tag from UI' (#262) from fix/issue-253 into main

crueber referenced this pull request