issue comment reactions - #31 isn't complete #42

New issue

Closed

opened 2026-09-04 17:09:39 +00:00 by crueber · 4 comments

crueber commented

2026-09-04 17:09:39 +00:00

Owner

The issue comments now show the reaction on the comment, that's great.

But when you click the button, nothing happens. It needs to show on the comment immediately.

It also should not add another comment that looks like the image that is attached to this issue.

The issue comments now show the reaction on the comment, that's great. But when you click the button, nothing happens. It needs to show on the comment immediately. It also should *not* add another comment that looks like the image that is attached to this issue. ![image](/attachments/fc3d8cce-571f-4701-b5a4-726811d7de1f)

image.png

9.5 KiB

crueber commented

2026-09-04 17:10:24 +00:00

Author

Owner

The reaction could still be part of the react feed (from an technical, event driven perspective), but it needs to not display that box for the reaction.

crueber referenced this issue from a commit

2026-09-04 20:02:06 +00:00

Fix #36, #42: reaction toggle/remove, immediate show, fold event rows (02_issues.md UI)

crueber referenced this issue from a pull request that will close it,

2026-09-04 20:02:13 +00:00

Fix #36, #42: reaction toggle/remove, immediate show, no comment-row #53

crueber commented

2026-09-04 20:02:25 +00:00

Author

Owner

Fix open in #53 (scratch-verified, needs review — do not merge yet): #53 — clicks paint immediately (optimistic, guarded-refetch reconciled) and reaction_changed events fold into the summary instead of rendering as comment rows.

Fix open in #53 (scratch-verified, needs review — do not merge yet): https://git.packden.us/crueber/walhub/pulls/53 — clicks paint immediately (optimistic, guarded-refetch reconciled) and reaction_changed events fold into the summary instead of rendering as comment rows.

crueber commented

2026-09-04 20:05:54 +00:00

Author

Owner

PR #53 review: reaction rows are fully folded (filter in Issue.jsx:79, no timeline path remains) — full findings on #36. Verified 227/227 node tests + vite/esbuild builds green. Recommendation: ready to merge.

crueber closed this issue

2026-09-04 20:06:08 +00:00

crueber commented

2026-09-04 20:06:09 +00:00

Author

Owner

Fixed by PR #53 (review clean; 227/227 node tests), merged. Closing.

crueber referenced this issue from a commit

2026-09-04 20:06:09 +00:00

Merge pull request 'Fix #36, #42: reaction toggle/remove, immediate show, no comment-row' (#53) from fix/issue-36-42 into main

crueber added the

issues