Fix #442: Edit profile on all views #448

Merged

crueber merged 1 commit from fix/issue-442 into main

2026-09-13 13:44:25 +00:00

crueber commented

2026-09-13 13:39:59 +00:00

Owner

Tests: new web/test/unit/owner-profile-edit-all-views-442.test.js (7 tests: form position above all three gates, no per-view copies, gate/onDone intact, shared-scope signal, button gate, #420 intact, no fetch/cache changes); updated 3 position-pinned suites (profile-sidebar-421, profile-header, profile-header-403). node --test: 942/944 pass, the 2 failures are the pre-existing smoke tests needing a live server (fail identically on pristine origin/main). vite build + esbuild SDK bundle green. No backend change, no new deps.

Fixes #442 (prescribed option 1): hoists the ProfileForm Show out of the view()==='profile' gate into the main column above the per-view Shows, so Edit profile opens on /:owner, /:owner/repositories, and /:owner/organizations. setEditing already lived at the shared OwnerPage scope — no plumbing. Gate and onDone byte-identical; #420 bio gate stays profile-view-only. Tests: new web/test/unit/owner-profile-edit-all-views-442.test.js (7 tests: form position above all three gates, no per-view copies, gate/onDone intact, shared-scope signal, button gate, #420 intact, no fetch/cache changes); updated 3 position-pinned suites (profile-sidebar-421, profile-header, profile-header-403). node --test: 942/944 pass, the 2 failures are the pre-existing smoke tests needing a live server (fail identically on pristine origin/main). vite build + esbuild SDK bundle green. No backend change, no new deps.

crueber added 1 commit

2026-09-13 13:39:59 +00:00

Fix #442 : Edit profile on all owner views (hoist form out of view gate) 182946bd51

Prescribed option 1: the ProfileForm Show moves from inside the
view()==='profile' gate to the main column above the per-view Shows,
so Edit profile opens on /:owner, /:owner/repositories, and
/:owner/organizations. Gate and onDone byte-identical; #420 bio gate
stays profile-view-only; no backend change, no new deps.

crueber referenced this pull request

2026-09-13 13:40:05 +00:00

Edit profile button does nothing from the repositories/organizations tabs (form renders only on the profile view) #442

crueber referenced this pull request

2026-09-13 13:44:08 +00:00

Edit profile button does nothing from the repositories/organizations tabs (form renders only on the profile view) #442

crueber merged commit eddc47f563 into main

2026-09-13 13:44:25 +00:00

crueber referenced this pull request from a commit

2026-09-13 13:44:26 +00:00

Merge pull request 'Fix #442: Edit profile on all views' (#448) from fix/issue-442 into main

crueber referenced this pull request