crueber/walhub
Watch
1
0
Fork
You've already forked walhub
 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity

Fix #458: failure-path residue #469

Merged
crueber merged 1 commit from fix/issue-458 into main 2026-09-13 16:37:36 +00:00
Conversation 0 Commits 1 Files changed 8 +977 -65
crueber commented 2026-09-13 16:32:38 +00:00
Owner
Copy link

Child of #449 (F4+F5). (1) Crash-safe fork retry: ShareManifest adopts orphan checkpoint keys by semantic compare and adopts an orphan child manifest when it provably tracks this parent (no fork.json, Repo/Rev1/seq/packs match) — retry converges instead of 409ing permanently; rival bytes 409 untouched, empty-parent and moved-parent orphans fail closed. (2) Rollback access.json ownership: deleted only when this attempt created it (EnsureRepoAccessCreated flag threaded runFork→RollbackShare); adopted pre-existing docs survive. Tests: new fork458_test.go (retry converges ×4 incl. provenance-committed crash; fail-closed ×8; rollback spares adopted; flag propagation; semantic compare) + EnsureRepoAccessCreated test; -race clean; pulls 96.1%, identity 95.6% (≥95 gate); fork e2e green. Docs: 03 decisions appended. No new deps.

Child of #449 (F4+F5). (1) Crash-safe fork retry: ShareManifest adopts orphan checkpoint keys by semantic compare and adopts an orphan child manifest when it provably tracks this parent (no fork.json, Repo/Rev1/seq/packs match) — retry converges instead of 409ing permanently; rival bytes 409 untouched, empty-parent and moved-parent orphans fail closed. (2) Rollback access.json ownership: deleted only when this attempt created it (EnsureRepoAccessCreated flag threaded runFork→RollbackShare); adopted pre-existing docs survive. Tests: new fork458_test.go (retry converges ×4 incl. provenance-committed crash; fail-closed ×8; rollback spares adopted; flag propagation; semantic compare) + EnsureRepoAccessCreated test; -race clean; pulls 96.1%, identity 95.6% (≥95 gate); fork e2e green. Docs: 03 decisions appended. No new deps.
ShareManifest adopts a crashed attempt's orphan checkpoint pair by
semantic compare (timestamps ignored) and an orphan child manifest when
it provably tracks this parent (Repo/Rev1/seq/packs, no fork.json), so a
retry converges instead of 409ing permanently; rival bytes 409 untouched
(sweep rejected: law 4). RollbackShare deletes access.json only when this
attempt created it (EnsureRepoAccessCreated flag). Decisions appended to
docs/features/03_pull_requests.md §7.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
actions

   
bug
Something is not working

  
cli

   
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
fork

   
forum

   
git storage

   
help wanted
Need some help

  
insights

   
invalid
Something is wrong

  
issues

   
moderation

   
oidc

   
ownership transfer

   
packages

   
pr/merge protection rules

   
projects

   
pull requests

   
question
More information is needed

  
releases

   
sponsorships

   
tags

   
webhooks

   
wiki

   
wontfix
This won't be fixed

No labels
actions
bug
cli
duplicate
enhancement
fork
forum
git storage
help wanted
insights
invalid
issues
moderation
oidc
ownership transfer
packages
pr/merge protection rules
projects
pull requests
question
releases
sponsorships
tags
webhooks
wiki
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
crueber/walhub!469
No description provided.