crueber/walhub
Watch
1
0
Fork
You've already forked walhub
 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity

Fix #463: pill spacing #473

Merged
crueber merged 1 commit from fix/issue-463 into main 2026-09-13 18:00:42 +00:00
Conversation 0 Commits 1 Files changed 2 +193 -54
crueber commented 2026-09-13 17:58:16 +00:00
Owner
Copy link

Preferred fix from the issue: TasksOverlay renders nothing when idle — the guard Show moved above the wrapper div (web/src/pages/Repo.jsx), so the Star/Watch/Fork/Clone row holds only real pills and its gap-2 owns every gap. The relative wrapper exists only with the pill and still anchors the tasks-drop popover when tasks run; Clone details-metrics unchanged; no backend change, no new deps. Extends the #447 contract comment to spacing (law-12 note in code). Sibling audit: Star/Watch return button straight out of Show, Fork is a bare A, Clone details IS the pill — no other empty flex items. Tests: new web/test/unit/header-gap-463.test.js (5 tests: idle-renders-nothing, gap ownership, pill+overlay intact, sibling audit, 390px arithmetic); targeted suites 55/55 green; full web suite 980/982 with the 2 smoke failures pre-existing on baseline (sandbox server answers 401); vite build clean. No browser drive (shared daemon blocks loopback per task note) — reasoning + headless + build only. Fixes #463.

Preferred fix from the issue: TasksOverlay renders nothing when idle — the guard Show moved above the wrapper div (web/src/pages/Repo.jsx), so the Star/Watch/Fork/Clone row holds only real pills and its gap-2 owns every gap. The relative wrapper exists only with the pill and still anchors the tasks-drop popover when tasks run; Clone details-metrics unchanged; no backend change, no new deps. Extends the #447 contract comment to spacing (law-12 note in code). Sibling audit: Star/Watch return button straight out of Show, Fork is a bare A, Clone details IS the pill — no other empty flex items. Tests: new web/test/unit/header-gap-463.test.js (5 tests: idle-renders-nothing, gap ownership, pill+overlay intact, sibling audit, 390px arithmetic); targeted suites 55/55 green; full web suite 980/982 with the 2 smoke failures pre-existing on baseline (sandbox server answers 401); vite build clean. No browser drive (shared daemon blocks loopback per task note) — reasoning + headless + build only. Fixes #463.
TasksOverlay returned an unconditional wrapper div whose inner Show guarded
only the pill, leaving an empty 0-width flex item in the Star/Watch/Fork/
Clone row when idle and doubling one gap to 2x gap-2. The guard Show now
sits above the wrapper div (preferred fix from the issue); the relative
wrapper exists only with the pill and still anchors the tasks-drop popover.
Extends the #447 contract comment to spacing; Clone details-metrics
unchanged. New headless test web/test/unit/header-gap-463.test.js.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
actions

   
bug
Something is not working

  
cli

   
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
fork

   
forum

   
git storage

   
help wanted
Need some help

  
insights

   
invalid
Something is wrong

  
issues

   
moderation

   
oidc

   
ownership transfer

   
packages

   
pr/merge protection rules

   
projects

   
pull requests

   
question
More information is needed

  
releases

   
sponsorships

   
tags

   
webhooks

   
wiki

   
wontfix
This won't be fixed

No labels
actions
bug
cli
duplicate
enhancement
fork
forum
git storage
help wanted
insights
invalid
issues
moderation
oidc
ownership transfer
packages
pr/merge protection rules
projects
pull requests
question
releases
sponsorships
tags
webhooks
wiki
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
crueber/walhub!473
No description provided.