crueber/walhub
Watch
1
0
Fork
You've already forked walhub
 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity

Fix #477: menu focus-first-item #478

Merged
crueber merged 1 commit from fix/issue-477 into main 2026-09-13 19:09:16 +00:00
Conversation 0 Commits 1 Files changed 3 +110 -6
crueber commented 2026-09-13 19:07:00 +00:00
Owner
Copy link

Fixes #477. Both navbar menus (CreateMenu.jsx, IdentityMenu.jsx) read getOpen() after setOpen() in toggle, so the focus-first-item branch never fired on open — Solid signals update synchronously. Now captures the pre-toggle value (const opening = !getOpen()) and guards the queueMicrotask first-item focus on it. Esc/outside-click/arrow/Tab popover contract untouched. Headless cover: web/test/unit/menu-focus-477.test.js (9 tests); targeted create-menu-466 + identity-nav + menu-focus-477: 53/53 green; full node --test: 885/900 with the same 15 failures as pristine origin/main (pre-existing, unrelated); vite build green. No backend change, no new deps. Browser proof open (shared-daemon loopback guard — not attempted per task).

Fixes #477. Both navbar menus (CreateMenu.jsx, IdentityMenu.jsx) read getOpen() after setOpen() in toggle, so the focus-first-item branch never fired on open — Solid signals update synchronously. Now captures the pre-toggle value (const opening = !getOpen()) and guards the queueMicrotask first-item focus on it. Esc/outside-click/arrow/Tab popover contract untouched. Headless cover: web/test/unit/menu-focus-477.test.js (9 tests); targeted create-menu-466 + identity-nav + menu-focus-477: 53/53 green; full node --test: 885/900 with the same 15 failures as pristine origin/main (pre-existing, unrelated); vite build green. No backend change, no new deps. Browser proof open (shared-daemon loopback guard — not attempted per task).
Both navbar menus read getOpen() after setOpen() in toggle, so the
focus-first-item branch never fired on open (Solid signals update
synchronously). Capture the pre-toggle value (const opening = !getOpen())
and guard the queueMicrotask first-item focus on it. Esc/outside-click/
arrow/Tab popover contract untouched.

Headless cover: web/test/unit/menu-focus-477.test.js.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
actions

   
bug
Something is not working

  
cli

   
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
fork

   
forum

   
git storage

   
help wanted
Need some help

  
insights

   
invalid
Something is wrong

  
issues

   
moderation

   
oidc

   
ownership transfer

   
packages

   
pr/merge protection rules

   
projects

   
pull requests

   
question
More information is needed

  
releases

   
sponsorships

   
tags

   
webhooks

   
wiki

   
wontfix
This won't be fixed

No labels
actions
bug
cli
duplicate
enhancement
fork
forum
git storage
help wanted
insights
invalid
issues
moderation
oidc
ownership transfer
packages
pr/merge protection rules
projects
pull requests
question
releases
sponsorships
tags
webhooks
wiki
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
crueber/walhub!478
No description provided.