Fix #495: tab-strip icon placement #496

Merged

crueber merged 1 commit from fix/issue-495 into main

2026-09-13 21:26:28 +00:00

crueber commented

2026-09-13 21:24:18 +00:00

Owner

Moves the #484/#485 icons off the repo tab strip onto the links they navigate to.

Deletes both icon blocks + isMilestonesPath/isLabelsPath helpers from web/src/pages/Repo.jsx (no icon renders on any tab under any path).
milestone-open leads the Milestones toolbar button, label leads the Labels toolbar button (web/src/pages/Issues.jsx), composing into the btn flow, decorative aria-hidden, link text unchanged.
Milestones page heading gains milestone-open in flex items-center gap-2 flow (planner's call, mirrors Labels.jsx:83).
lib/tabs.js mapping (labels/milestones -> issues) unchanged; #319 badge + #274 scroll intact; no per-icon classes; no new deps.
icons.jsx header consumer list rewritten (two strip items -> toolbar-links item + milestones-heading item; twelve-surface count holds); law-12 decision appended to docs/go/12_web_ui.md.

Tests: web/test/unit/milestone-icons-484.test.js + label-icon-485.test.js pins rewritten (no-strip/no-helper, toolbar order, heading). Full node --test web/test/unit: 1088 pass, 2 fail — the 2 failures are the pre-existing live-server smoke subtests (need a live Go server, identical on pristine origin/main). vite build green. Browser proof open (shared-daemon loopback guard — no private daemon per workspace rules).

Moves the #484/#485 icons off the repo tab strip onto the links they navigate to. - Deletes both <Show> icon blocks + isMilestonesPath/isLabelsPath helpers from web/src/pages/Repo.jsx (no icon renders on any tab under any path). - milestone-open leads the Milestones toolbar button, label leads the Labels toolbar button (web/src/pages/Issues.jsx), composing into the btn flow, decorative aria-hidden, link text unchanged. - Milestones page heading gains milestone-open in flex items-center gap-2 flow (planner's call, mirrors Labels.jsx:83). - lib/tabs.js mapping (labels/milestones -> issues) unchanged; #319 badge + #274 scroll intact; no per-icon classes; no new deps. - icons.jsx header consumer list rewritten (two strip items -> toolbar-links item + milestones-heading item; twelve-surface count holds); law-12 decision appended to docs/go/12_web_ui.md. Tests: web/test/unit/milestone-icons-484.test.js + label-icon-485.test.js pins rewritten (no-strip/no-helper, toolbar order, heading). Full node --test web/test/unit: 1088 pass, 2 fail — the 2 failures are the pre-existing live-server smoke subtests (need a live Go server, identical on pristine origin/main). vite build green. Browser proof open (shared-daemon loopback guard — no private daemon per workspace rules).

crueber added 1 commit

2026-09-13 21:24:18 +00:00

Fix #495 : tab-strip icon placement 438177d251

Removes the #484/#485 option-(a) strip icons (both <Show> blocks +
isMilestonesPath/isLabelsPath helpers) from Repo.jsx — they painted the
milestone/label icons on the Issues tab instead of the Milestones/Labels
links. The milestone-open icon now leads the Milestones toolbar button
and the label icon the Labels toolbar button on Issues.jsx; the
Milestones page heading gains the open icon (planner's call, mirrors
Labels.jsx:83). tabs.js mapping, #319 badge, #274 scroll unchanged;
decorative aria-hidden, no per-icon classes, no new deps. Decision
recorded in docs/go/12_web_ui.md (law 12).

crueber referenced this pull request

2026-09-13 21:24:21 +00:00

Milestone/label tab-strip icons from #484/#485 mount on the Issues tab instead of the Milestones/Labels links #495

crueber referenced this pull request

2026-09-13 21:26:12 +00:00

Milestone/label tab-strip icons from #484/#485 mount on the Issues tab instead of the Milestones/Labels links #495

crueber merged commit b3544e5d2e into main

2026-09-13 21:26:28 +00:00

crueber referenced this pull request from a commit

2026-09-13 21:26:29 +00:00

Merge pull request 'Fix #495: tab-strip icon placement' (#496) from fix/issue-495 into main

crueber referenced this pull request