crueber/walhub
Watch
1
0
Fork
You've already forked walhub
 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity

Fix #544: diff row backgrounds #548

Merged
crueber merged 1 commit from fix/issue-544 into main 2026-09-14 23:14:43 +00:00
Conversation 0 Commits 1 Files changed 7 +165 -7
crueber commented 2026-09-14 22:53:16 +00:00
Owner
Copy link

Styling only: added/removed diff lines now carry full-row light green/red backgrounds (gutter cells included) on all diff surfaces (commit diff, PR Files tab via shared DiffBody; main PR conversation diff via DiffFile), both themes. Per-cell lineClass() (split pairs stay red-left/green-right); compound .diff-num.diff-add/.diff-del gutter tiebreaks in ui.css; unlayered line-hl selection still wins. diff.js untouched (hash vectors green). Tests: new diff-row-544.test.js (9 tests) + 1 stale pin updated; full node suite 1250/1249 (1 pre-existing live-server smoke failure, verified head-to-head on main); vite+esbuild green. Browser proof open (no browser available — shared daemon blocks loopback; verified by reasoning + tests, noted in the 12_web_ui.md decision). No new deps.

Styling only: added/removed diff lines now carry full-row light green/red backgrounds (gutter cells included) on all diff surfaces (commit diff, PR Files tab via shared DiffBody; main PR conversation diff via DiffFile), both themes. Per-cell lineClass() (split pairs stay red-left/green-right); compound .diff-num.diff-add/.diff-del gutter tiebreaks in ui.css; unlayered line-hl selection still wins. diff.js untouched (hash vectors green). Tests: new diff-row-544.test.js (9 tests) + 1 stale pin updated; full node suite 1250/1249 (1 pre-existing live-server smoke failure, verified head-to-head on main); vite+esbuild green. Browser proof open (no browser available — shared daemon blocks loopback; verified by reasoning + tests, noted in the 12_web_ui.md decision). No new deps.
DiffTable.jsx applies the shared lineClass() per cell (unified: gutter +
code; split: per side, so paired change rows stay red-left/green-right);
Pull.jsx DiffFile reuses it on its row divs; ui.css gains compound
.diff-num.diff-add/.diff-del gutter tiebreaks (both themes); unlayered
.diff-row.line-hl selection still wins. Styling only - diff.js untouched.
Guideline §8 extended + 12_web_ui.md decision (laws 11/12).
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
actions

   
bug
Something is not working

  
cli

   
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
fork

   
forum

   
git storage

   
help wanted
Need some help

  
insights

   
invalid
Something is wrong

  
issues

   
moderation

   
oidc

   
ownership transfer

   
packages

   
pr/merge protection rules

   
projects

   
pull requests

   
question
More information is needed

  
releases

   
sponsorships

   
tags

   
webhooks

   
wiki

   
wontfix
This won't be fixed

No labels
actions
bug
cli
duplicate
enhancement
fork
forum
git storage
help wanted
insights
invalid
issues
moderation
oidc
ownership transfer
packages
pr/merge protection rules
projects
pull requests
question
releases
sponsorships
tags
webhooks
wiki
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
crueber/walhub!548
No description provided.