FinishReview form + ThreadIndex nav lack card padding (unpadded siblings) #557

New issue

Closed

opened 2026-09-15 02:59:15 +00:00 by crueber · 2 comments

crueber commented

2026-09-15 02:59:15 +00:00

Owner

Follow-up flagged by the #554 review (PR #556 findings). The FinishReview form and ThreadIndex nav render without card padding, same flat-read problem #554 fixed for the Reviews section. Compose them with the sibling card/padding idioms.

crueber referenced this issue

2026-09-15 03:00:02 +00:00

Reviews section and finish-review trigger do not match sibling containers (card padding, button treatment) #554

crueber referenced this issue from a commit

2026-09-15 04:13:51 +00:00

Fix #557: FinishReview form + ThreadIndex nav take the sibling card padding (docs/go/12_web_ui.md amendment + style-guideline §2 by reference)

crueber referenced this issue from a pull request that will close it,

2026-09-15 04:13:52 +00:00

Fix #557: unpadded siblings #559

crueber commented

2026-09-15 04:13:55 +00:00

Author

Owner

Fix up at #559 (branch fix/issue-557): FinishReview form → card p-3, ThreadIndex nav → card mb-4 p-3, composing the ReviewsList #554 / CommentComposer sibling idiom. Styling/markup only. node --test 1306 total / 1305 pass / 1 pre-existing live-server smoke failure; vite + esbuild green. No browser proof from this rig (shared daemon blocks loopback) — please screenshot-verify pre-merge.

Fix up at https://git.packden.us/crueber/walhub/pulls/559 (branch fix/issue-557): FinishReview form → card p-3, ThreadIndex nav → card mb-4 p-3, composing the ReviewsList #554 / CommentComposer sibling idiom. Styling/markup only. node --test 1306 total / 1305 pass / 1 pre-existing live-server smoke failure; vite + esbuild green. No browser proof from this rig (shared daemon blocks loopback) — please screenshot-verify pre-merge.

crueber closed this issue

2026-09-15 11:28:53 +00:00

crueber referenced this issue from a commit

2026-09-15 11:28:54 +00:00

Merge pull request 'Fix #557: unpadded siblings' (#559) from fix/issue-557 into main

crueber commented

2026-09-15 11:29:04 +00:00

Author

Owner

Fixed by #559 (merged): FinishReview form and ThreadIndex nav now compose the sibling card padding (card p-3 / card mb-4 p-3, the ReviewsList #554 idiom). Verified: 1303 unit tests green (smoke excluded, pre-existing live-server failure only), targeted suites 22/22, vite+esbuild green, go vet clean, independent review APPROVE.