Remove the comment counts from the Comments index heading #572

New issue

Closed

opened 2026-09-15 14:02:49 +00:00 by crueber · 1 comment

crueber commented

2026-09-15 14:02:49 +00:00

Owner

Remove the comment counts from the Comments index heading

What's requested

The thread index panel above the PR conversation renders its heading as a count, e.g. "Comments (3 + 1 staged)". Drop the counts: the heading should read just "Comments". The pills themselves already carry the useful per-thread state (path:line, resolved/outdated/staged markers), and the review summary bar already reports "N unresolved threads" — the parenthetical count is redundant chrome on this panel.

Evidence

web/src/pages/Pull.jsx:814-816 (ThreadIndex): <h2 class="card-header">Comments ({(props.threads ?? []).length}{(props.pending ?? []).length > 0 ? \ + ${(props.pending ?? []).length} staged` : ""})`.

Architecture notes

Display-only change inside ThreadIndex; no wire, store, or cache surface is touched (the heading count is computed from props the panel already receives).
Staged entries remain discoverable through the staged pills in the same panel (marked "staged", per #567) — the count is not their only signal.

Acceptance criteria

The Comments index heading renders "Comments" with no parenthetical count in every state (threads only, threads + staged, staged only, gone-marked threads).
The panel still appears exactly when it appears today (threads or pending non-empty — Pull.jsx:812); the visibility gate does not become count-dependent.
Pills, jump, and flash behavior are unchanged.
Existing unit tests for the panel still pass.

# Remove the comment counts from the Comments index heading ## What's requested The thread index panel above the PR conversation renders its heading as a count, e.g. "Comments (3 + 1 staged)". Drop the counts: the heading should read just "Comments". The pills themselves already carry the useful per-thread state (path:line, resolved/outdated/staged markers), and the review summary bar already reports "N unresolved threads" — the parenthetical count is redundant chrome on this panel. ## Evidence - `web/src/pages/Pull.jsx:814-816` (ThreadIndex): `<h2 class="card-header">Comments ({(props.threads ?? []).length}{(props.pending ?? []).length > 0 ? \` + ${(props.pending ?? []).length} staged\` : ""})</h2>`. ## Architecture notes - Display-only change inside `ThreadIndex`; no wire, store, or cache surface is touched (the heading count is computed from props the panel already receives). - Staged entries remain discoverable through the staged pills in the same panel (marked "staged", per #567) — the count is not their only signal. ## Acceptance criteria - [ ] The Comments index heading renders "Comments" with no parenthetical count in every state (threads only, threads + staged, staged only, gone-marked threads). - [ ] The panel still appears exactly when it appears today (`threads` or `pending` non-empty — Pull.jsx:812); the visibility gate does not become count-dependent. - [ ] Pills, jump, and flash behavior are unchanged. - [ ] Existing unit tests for the panel still pass.

crueber added the

bug

pull requests

labels

2026-09-15 14:03:08 +00:00

crueber added this to the v1 milestone

2026-09-15 14:03:08 +00:00

crueber added the

issues

label

2026-09-15 14:03:49 +00:00

crueber referenced this issue from a commit

2026-09-15 14:39:37 +00:00

FIXED (Forgejo #572) — ThreadIndex heading renders just Comments, no counts

crueber referenced this issue from a pull request that will close it,

2026-09-15 14:39:39 +00:00

Fix #572: ThreadIndex heading renders just Comments, no counts #576

crueber referenced this issue

2026-09-15 14:40:52 +00:00

Fix #572: ThreadIndex heading renders just Comments, no counts #576

crueber closed this issue

2026-09-15 14:41:06 +00:00

crueber commented

2026-09-15 14:41:06 +00:00

Author

Owner

Fixed by #576 (merged): ThreadIndex heading renders static Comments with no parenthetical count in every state; gate, pills, jump/flash byte-identical. Verified: 1393 unit tests green (smoke excluded, pre-existing), vite/esbuild green, independent review APPROVE.

crueber referenced this issue from a commit

2026-09-15 14:41:06 +00:00

Merge pull request 'Fix #572: ThreadIndex heading renders just Comments, no counts' (#576) from fix/issue-572 into main