Remove duplicated 'Able to be Merged' headline from the MERGE section (keep the sidebar one) #592

Closed
opened 2026-09-15 19:33:35 +00:00 by crueber · 1 comment
Owner

What's observed

The PR sidebar renders "Able to be Merged" twice (screenshot): once under MERGEABILITY at the top (the Pull.jsx:1384 sidebar value via mergeabilityDisplay, #588) and once under MERGE (the MergeBox state line at MergeBox.jsx:164, also #588). Keep only the top one.

What's requested

Remove the state headline from MergeBox — the disp() line rendering the mergeabilityDisplay text — so the sidebar MERGEABILITY value is the single status headline. The amber "blocking merge: …" reasons line (MergeBox.jsx:194-197) stays: it is not duplicated and carries remediation detail. When mergeable, the MERGE section shows Strategy + buttons with no status line.

Acceptance criteria

  • MERGE section shows no Able-to-be-Merged/blocked headline; the sidebar headline is unchanged.
  • The blocked-reasons line still renders in MergeBox when blocked.
  • mergeabilityDisplay helper retained for the sidebar (no per-callsite fork); dead MergeBox plumbing (disp memo, zeroChecks prop if now unused) removed cleanly.
  • #588 test pins updated from MergeBox-usage to MergeBox-absence pins (justified update, not weakening); full suite green.
## What's observed The PR sidebar renders "Able to be Merged" twice (screenshot): once under MERGEABILITY at the top (the Pull.jsx:1384 sidebar value via mergeabilityDisplay, #588) and once under MERGE (the MergeBox state line at MergeBox.jsx:164, also #588). Keep only the top one. ## What's requested Remove the state headline from MergeBox — the disp() line rendering the mergeabilityDisplay text — so the sidebar MERGEABILITY value is the single status headline. The amber "blocking merge: …" reasons line (MergeBox.jsx:194-197) stays: it is not duplicated and carries remediation detail. When mergeable, the MERGE section shows Strategy + buttons with no status line. ## Acceptance criteria - [ ] MERGE section shows no Able-to-be-Merged/blocked headline; the sidebar headline is unchanged. - [ ] The blocked-reasons line still renders in MergeBox when blocked. - [ ] mergeabilityDisplay helper retained for the sidebar (no per-callsite fork); dead MergeBox plumbing (disp memo, zeroChecks prop if now unused) removed cleanly. - [ ] #588 test pins updated from MergeBox-usage to MergeBox-absence pins (justified update, not weakening); full suite green.
crueber added this to the v1 milestone 2026-09-15 19:33:35 +00:00
Author
Owner

Fixed by #593 (merged): MergeBox state headline removed — the sidebar MERGEABILITY value is now the single status headline; blocked-reasons line, tooltip, gate, and strategy/buttons untouched; dead disp/zeroChecks plumbing removed; helper retained for the sidebar. Verified: 1486 unit tests green (smoke excluded, pre-existing), vite/esbuild green, independent review APPROVE.

Fixed by #593 (merged): MergeBox state headline removed — the sidebar MERGEABILITY value is now the single status headline; blocked-reasons line, tooltip, gate, and strategy/buttons untouched; dead disp/zeroChecks plumbing removed; helper retained for the sidebar. Verified: 1486 unit tests green (smoke excluded, pre-existing), vite/esbuild green, independent review APPROVE.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
crueber/walhub#592
No description provided.