Settings: merge Mirror and Push mirror sidebar entries into one section with two containers #627

New issue

Closed

opened 2026-09-16 18:01:41 +00:00 by crueber · 1 comment

crueber commented

2026-09-16 18:01:41 +00:00

Owner

What's requested

The Settings sidebar has two separate mirror entries (Mirror for pull, Push mirror). Combine them into ONE sidebar entry that renders TWO containers: the pull-mirror panel and the push-mirror panel, grouped together.

Acceptance criteria

One mirror nav entry in the Settings sidebar (no separate Push mirror row); selecting it shows both the pull-mirror and push-mirror containers.
Both containers keep their current content/behavior (config, status, actions); purely a nav/grouping change.
Deep links: #mirror keeps working; #pushmirror resolves to the merged entry (no dead hash).
Settings tab registry (settingsNav.js) updated; unit tests pin the single entry + both containers.

## What's requested The Settings sidebar has two separate mirror entries (Mirror for pull, Push mirror). Combine them into ONE sidebar entry that renders TWO containers: the pull-mirror panel and the push-mirror panel, grouped together. ## Acceptance criteria - [ ] One mirror nav entry in the Settings sidebar (no separate Push mirror row); selecting it shows both the pull-mirror and push-mirror containers. - [ ] Both containers keep their current content/behavior (config, status, actions); purely a nav/grouping change. - [ ] Deep links: #mirror keeps working; #pushmirror resolves to the merged entry (no dead hash). - [ ] Settings tab registry (settingsNav.js) updated; unit tests pin the single entry + both containers.

crueber added this to the v1 milestone

2026-09-16 18:01:41 +00:00

crueber added the

enhancement

issues

labels

2026-09-16 18:01:41 +00:00

crueber referenced this issue from a commit

2026-09-16 18:04:23 +00:00

Merge Settings Mirror + Push mirror into one sidebar entry (Fix #627)

crueber referenced this issue from a pull request that will close it,

2026-09-16 18:04:24 +00:00

Merge Settings Mirror + Push mirror into one entry (Fix #627) #628

crueber referenced this issue

2026-09-16 18:06:15 +00:00

Merge Settings Mirror + Push mirror into one entry (Fix #627) #628

crueber closed this issue

2026-09-16 18:06:42 +00:00

crueber referenced this issue from a commit

2026-09-16 18:06:43 +00:00

Merge pull request 'Merge Settings Mirror + Push mirror into one entry (Fix #627)' (#628) from fix/issue-627 into main

crueber commented

2026-09-16 18:06:43 +00:00

Author

Owner

Fixed by #628 (merged): single Mirror sidebar entry rendering both pull and push containers (pull-then-push, unchanged props/fetches); #pushmirror deep links alias to it; unknown hashes still fall back to General. Verified: 1619 unit green (smoke excluded, pre-existing), vite/esbuild green, independent review APPROVE.