Separate Mirror tab cards with the stacked-section gap (Fix #629) #630

Merged

crueber merged 1 commit from fix/issue-629 into main

2026-09-18 19:14:49 +00:00

crueber commented

2026-09-18 19:13:25 +00:00

Owner

Fixes #629. Push-mirror card takes the file's stacked-section idiom (card mt-4 p-4, 8x pre-existing) so the two containers read as distinct. Same cards/content/order/fetches. Verified: new test 3/3, full-minus-smoke 1622/1622, vite+esbuild green, go vet clean.

crueber added 1 commit

2026-09-18 19:13:25 +00:00

Separate Mirror tab cards with the stacked-section gap (Forgejo #629 ) 62a2e61c6b

crueber commented

2026-09-18 19:14:35 +00:00

Author

Owner

Independent review — APPROVED (Forgejo #629 acceptance met, no changes needed).

Verified against origin/main..origin/fix/issue-629 (62a2e61, 3 files +50/-1):

PUSH-card root only: word-diff of Settings.jsx shows the single class string card p-4 → card mt-4 p-4 on PushMirrorTab's root section (line ~946) plus the #629 comment. Nothing else touched.
Not MirrorTab, not shared: MirrorTab root (card p-4, ~line 682) byte-identical — confirmed by diffing the MirrorTab function body main-vs-branch (identical). PushMirrorTab has exactly one render site: the merged getTab() === "mirror" branch (line 1880, pull-then-push order kept); no shared component involved.
No other class changed on either card: full-file diff contains only the one class string + comment (word-diff inspected).
File idiom: card mt-4 p-4 matches the stacked-section idiom used by 8+ sibling sections in the same file (lines 508/522/534/1213/1323/1347/1441/1732); mt-4 = 1rem Tailwind default, no custom value.
Both themes: margin utilities are theme-independent — trivially holds; no color/surface classes touched.
390px: margin stacks vertically, no fixed widths introduced (diff adds no width/min-width/flex-row classes).
Law 12: docs/go/12_web_ui.md gains a FIXED (#629) entry in the same change.
Law 1: no new CSS (ui.css untouched, test pins no mirror-gap/sibling-selector CSS), no new deps (only solid-js/router idiom already in file).
Pre-fix failure: extracted origin/main Settings.jsx — push root is card p-4 (no mt-4), so the new test's push-card assertion fails on main and passes on the branch. Test run on branch: 3/3 pass; full unit suite minus smoke: 1622/1622 pass. (smoke.test.js hits a stray server on 127.0.0.1:8080 → 403; environmental, out of scope per the change's own 'minus smoke' pin.)

No fix commits — nothing to change. Ready to merge.

Independent review — APPROVED (Forgejo #629 acceptance met, no changes needed). Verified against origin/main..origin/fix/issue-629 (62a2e61, 3 files +50/-1): - PUSH-card root only: word-diff of Settings.jsx shows the single class string `card p-4` → `card mt-4 p-4` on PushMirrorTab's root section (line ~946) plus the #629 comment. Nothing else touched. - Not MirrorTab, not shared: MirrorTab root (`card p-4`, ~line 682) byte-identical — confirmed by diffing the MirrorTab function body main-vs-branch (identical). PushMirrorTab has exactly one render site: the merged `getTab() === "mirror"` branch (line 1880, pull-then-push order kept); no shared component involved. - No other class changed on either card: full-file diff contains only the one class string + comment (word-diff inspected). - File idiom: `card mt-4 p-4` matches the stacked-section idiom used by 8+ sibling sections in the same file (lines 508/522/534/1213/1323/1347/1441/1732); mt-4 = 1rem Tailwind default, no custom value. - Both themes: margin utilities are theme-independent — trivially holds; no color/surface classes touched. - 390px: margin stacks vertically, no fixed widths introduced (diff adds no width/min-width/flex-row classes). - Law 12: docs/go/12_web_ui.md gains a FIXED (#629) entry in the same change. - Law 1: no new CSS (ui.css untouched, test pins no `mirror-gap`/sibling-selector CSS), no new deps (only solid-js/router idiom already in file). - Pre-fix failure: extracted origin/main Settings.jsx — push root is `card p-4` (no mt-4), so the new test's push-card assertion fails on main and passes on the branch. Test run on branch: 3/3 pass; full unit suite minus smoke: 1622/1622 pass. (smoke.test.js hits a stray server on 127.0.0.1:8080 → 403; environmental, out of scope per the change's own 'minus smoke' pin.) No fix commits — nothing to change. Ready to merge.

crueber merged commit 41ff8aa0fc into main

2026-09-18 19:14:49 +00:00

crueber referenced this pull request from a commit

2026-09-18 19:14:50 +00:00

Merge pull request 'Separate Mirror tab cards with the stacked-section gap (Fix #629)' (#630) from fix/issue-629 into main

crueber referenced this pull request

2026-09-18 19:14:50 +00:00

Mirror tab: pull and push containers touch — separate them visually #629