Fix #90: scrub credentials from delivery errors

crueber commented

2026-09-05 02:43:19 +00:00

Owner

Scubs userinfo, sensitive query values, fragments, KV secrets, and bearer material from webhook transport errors before they persist into the deliveries ring (bucket + admin API). Diagnostic shape retained (host/path/non-secret keys). No deliveries shape change, so no doc update (law 12). Tests: TestScrubDeliveryError (unit table) + TestWebhookDeliveryErrorScrubbed (failing delivery against a userinfo URL); package 97.2% coverage, -race green. Note: rings written before this fix still hold old raw errors until they trim; no migration.

crueber added 1 commit

2026-09-05 02:43:19 +00:00

Fix #90 : scrub credentials from webhook delivery errors 0fdfe8a900

recordDelivery persisted raw derr.Error() into the deliveries ring;
Go transport errors echo the hook URL, leaking userinfo and query
tokens to the bucket + admin API. Scrub userinfo, sensitive query
values, fragments, KV secrets, and bearer material before storing;
diagnostic shape (host/path/non-secret keys) retained. No deliveries
shape change (Error stays string), so no doc update (law 12).

crueber referenced this pull request

2026-09-05 02:43:22 +00:00

[minor-5] Webhook transport errors persist raw userinfo URLs into the bucket #90

crueber referenced this pull request

2026-09-05 02:45:36 +00:00

[minor-5] Webhook transport errors persist raw userinfo URLs into the bucket #90

crueber merged commit 5cc488a07c into main

2026-09-05 02:45:48 +00:00

crueber referenced this pull request

2026-09-05 02:45:49 +00:00

[minor-5] Webhook transport errors persist raw userinfo URLs into the bucket #90

crueber referenced this pull request from a commit

2026-09-05 02:45:50 +00:00

Merge pull request 'Fix #90: scrub credentials from delivery errors' (#99) from fix/issue-90 into main

Rows
Columns

Fix #90: scrub credentials from delivery errors #99