Design update on issue list page #135

New issue

Closed

opened 2026-09-05 14:47:37 +00:00 by crueber · 3 comments

crueber commented

2026-09-05 14:47:37 +00:00

Owner

Move the state after the title instead of before. It offsets it weirdly.

Remove the container, and use a border instead, kind of like it is now over in the issue view page for comments.

![image](/attachments/77a6b642-a3f2-46ac-b35d-060d2e4ed41e) Move the state after the title instead of before. It offsets it weirdly. Remove the container, and use a border instead, kind of like it is now over in the issue view page for comments.

image.png

39 KiB

crueber referenced this issue from a commit

2026-09-05 15:50:21 +00:00

Fix #135: issue list rows — title-first pill, divider separators

crueber referenced this issue from a pull request that will close it,

2026-09-05 15:50:24 +00:00

Fix #135: issue list rows #140

crueber commented

2026-09-05 15:50:28 +00:00

Author

Owner

Fixed by #140 (branch fix/issue-135): pill after title, divider-separated rows per the #109 timeline style. Pulls.jsx left as-is — same treatment proposed as follow-up.

Fixed by #140 (branch `fix/issue-135`): pill after title, divider-separated rows per the #109 timeline style. Pulls.jsx left as-is — same treatment proposed as follow-up.

crueber commented

2026-09-05 15:52:51 +00:00

Author

Owner

Review of PR #140 (fix/issue-135, 8c9ee06) — issue list rows.

Scope: Issues.jsx only (23+/17-, 1 file). Law 1/7/8/12 clean: no import or dep changes, no new CSS tokens, page-level change only, no doc conflict (12_web_ui.md does not pin row style).

Verified, all good:

Title-first then state pill in every row (Issues.jsx:143-149): single For branch, no old-order row remains. BEFORE shot showed pill-before-title boxed cards; that order is gone.
Containers replaced by dividers: ul drops grid gap-2 (Issues.jsx:134), rows drop .card for border-t border-zinc-200 py-3 first:border-t-0 first:pt-0 dark:border-zinc-800 (Issues.jsx:141) — byte-identical to the ThreadTimeline comment-entry tokens (ThreadTimeline.jsx:52). First row flush via first: tokens. Filter form keeps its .card (filter bar, not a row — correct).
Labels chips + meta + filters + Older pagination intact: LabelChip/colorMap (154-160), comment_count + DateTime meta (150-152), filter bar (78-117), Older/more button (166-177) all untouched. Label row w-full to mt-1 is correct inside the new block layout.
No new CSS/classes or deps: every token already in use (ThreadTimeline/App footer); no import, package.json, or ui.css change.
Dark+light via shared tokens: border-zinc-200/dark:border-zinc-800, title emerald-700/400, meta zinc-500/400.
Pulls.jsx follow-up note accurate: Pulls.jsx:96,99 still uses card-list/card with pill-in-meta — genuinely a different pattern, follow-up justified.

Tests (scratch worktree /tmp/pr140 @ 8c9ee06; node_modules symlinked from main worktree, read-only): node --test web/test/unit/*.test.js — 309 pass, 0 fail. vite build — clean (117 modules, 1.77s). No browser drive per instructions (node tests + reasoning); no visual regression check beyond BEFORE shot. No fixes pushed — nothing to fix.

Recommendation: ready to merge.

Review of PR #140 (fix/issue-135, 8c9ee06) — issue list rows. Scope: Issues.jsx only (23+/17-, 1 file). Law 1/7/8/12 clean: no import or dep changes, no new CSS tokens, page-level change only, no doc conflict (12_web_ui.md does not pin row style). Verified, all good: - Title-first then state pill in every row (Issues.jsx:143-149): single For branch, no old-order row remains. BEFORE shot showed pill-before-title boxed cards; that order is gone. - Containers replaced by dividers: ul drops grid gap-2 (Issues.jsx:134), rows drop .card for border-t border-zinc-200 py-3 first:border-t-0 first:pt-0 dark:border-zinc-800 (Issues.jsx:141) — byte-identical to the ThreadTimeline comment-entry tokens (ThreadTimeline.jsx:52). First row flush via first: tokens. Filter form keeps its .card (filter bar, not a row — correct). - Labels chips + meta + filters + Older pagination intact: LabelChip/colorMap (154-160), comment_count + DateTime meta (150-152), filter bar (78-117), Older/more button (166-177) all untouched. Label row w-full to mt-1 is correct inside the new block layout. - No new CSS/classes or deps: every token already in use (ThreadTimeline/App footer); no import, package.json, or ui.css change. - Dark+light via shared tokens: border-zinc-200/dark:border-zinc-800, title emerald-700/400, meta zinc-500/400. - Pulls.jsx follow-up note accurate: Pulls.jsx:96,99 still uses card-list/card with pill-in-meta — genuinely a different pattern, follow-up justified. Tests (scratch worktree /tmp/pr140 @ 8c9ee06; node_modules symlinked from main worktree, read-only): node --test web/test/unit/*.test.js — 309 pass, 0 fail. vite build — clean (117 modules, 1.77s). No browser drive per instructions (node tests + reasoning); no visual regression check beyond BEFORE shot. No fixes pushed — nothing to fix. Recommendation: ready to merge.

crueber closed this issue

2026-09-05 15:53:09 +00:00

crueber commented

2026-09-05 15:53:10 +00:00

Author

Owner

Fixed by PR #140 (review clean; divider tokens byte-identical to timeline; 309/309 node tests), merged. Closing.

crueber referenced this issue from a commit

2026-09-05 15:53:11 +00:00

Merge pull request 'Fix #135: issue list rows' (#140) from fix/issue-135 into main

crueber added the

issues