Only some code tab breadcrumbs work. #189

New issue

Closed

opened 2026-09-08 12:14:23 +00:00 by crueber · 3 comments

crueber commented

2026-09-08 12:14:23 +00:00

Owner

The "docs" link in the image doesn't have the branch on it, but the root works fine.

Make it so that the breadcrumbs link up correctly for where you are in the repo.

![image](/attachments/a50b70ae-fa33-44a4-8075-8574da0250c8) The "docs" link in the image doesn't have the branch on it, but the root works fine. Make it so that the breadcrumbs link up correctly for where you are in the repo.

image.png

26 KiB

crueber referenced this issue from a commit

2026-09-08 12:30:11 +00:00

Fix #189: Tree breadcrumb segment links carry the ref

crueber referenced this issue from a pull request that will close it,

2026-09-08 12:30:13 +00:00

Fix #189: breadcrumb segment links carry ref #192

crueber commented

2026-09-08 12:30:19 +00:00

Author

Owner

Fix ready for review: PR #192 (branch fix/issue-189) — Tree breadcrumb intermediate segments now link /{full}/tree/{ref}/{subpath}, mirroring Blob. Browser-verified on a nested path with zero console errors.

crueber commented

2026-09-08 12:33:14 +00:00

Author

Owner

Review of PR #192 (fix/issue-189) — verified in scratch worktree, main untouched.

Findings (all resolved, no changes needed):

web/src/pages/Tree.jsx:25 — intermediate hrefs now /{full}/tree/{shortRef(rev)}/{subpath}, byte-identical shape to Blob.jsx:30 proven pattern. Root link (line 19) and current-segment unchanged. shortRef was already imported (line 10); no new deps (law 1 clean).

web/src/pages/Tree.jsx:192 — rev={t().ref} is the right source: useResolved attaches the user-resolved ref onto the payload (data.js:343-345), symmetric with Blob's rev={b().ref} (Blob.jsx:71). Consistent with existing in-file uses (treeRest:189, docRef:225).

web/test/unit/breadcrumb-head.test.js:45-55 — regression test pins the exact href shape plus rev threading; #29 cases (root-first, Blob rev) intact.

Laws 7/8: N/A beyond a link fix; no seam or core-package changes. Law 12: no doc change needed — 12_web_ui.md:485 already states the breadcrumb carries ref+path.

Verify: node --test web/test/unit/*.test.js 387/387 green in scratch (node_modules symlinked from main, removed after); vite build clean (125 modules, 1.62s). Scratch worktree removed. No browser drive (node tests + source reasoning per task note).

MERGE RECOMMENDATION: ready to merge.

Review of PR #192 (fix/issue-189) — verified in scratch worktree, main untouched. Findings (all resolved, no changes needed): - web/src/pages/Tree.jsx:25 — intermediate hrefs now `/{full}/tree/{shortRef(rev)}/{subpath}`, byte-identical shape to Blob.jsx:30 proven pattern. Root link (line 19) and current-segment <strong> unchanged. shortRef was already imported (line 10); no new deps (law 1 clean). - web/src/pages/Tree.jsx:192 — `rev={t().ref}` is the right source: useResolved attaches the user-resolved ref onto the payload (data.js:343-345), symmetric with Blob's `rev={b().ref}` (Blob.jsx:71). Consistent with existing in-file uses (treeRest:189, docRef:225). - web/test/unit/breadcrumb-head.test.js:45-55 — regression test pins the exact href shape plus rev threading; #29 cases (root-first, Blob rev) intact. - Laws 7/8: N/A beyond a link fix; no seam or core-package changes. Law 12: no doc change needed — 12_web_ui.md:485 already states the breadcrumb carries ref+path. Verify: node --test web/test/unit/*.test.js 387/387 green in scratch (node_modules symlinked from main, removed after); vite build clean (125 modules, 1.62s). Scratch worktree removed. No browser drive (node tests + source reasoning per task note). MERGE RECOMMENDATION: ready to merge.

crueber closed this issue

2026-09-08 12:33:37 +00:00

crueber commented

2026-09-08 12:33:37 +00:00

Author

Owner

Fixed by PR #192 (review clean; Tree mirrors Blob's proven href shape; 387/387), merged. Closing.

crueber referenced this issue from a commit

2026-09-08 12:33:37 +00:00

Merge pull request 'Fix #189: breadcrumb segment links carry ref' (#192) from fix/issue-189 into main

crueber added the

git storage