Fix #189: breadcrumb segment links carry ref #192

Merged

crueber merged 1 commit from fix/issue-189 into main

2026-09-08 12:33:36 +00:00

crueber commented

2026-09-08 12:30:13 +00:00

Owner

Tree Breadcrumb built intermediate hrefs as /{full}/tree/{subpath}, dropping the display ref, so nested crumbs (e.g. docs in docs/go) missed the branch while root worked. Now passes rev={t().ref} and renders /{full}/tree/{shortRef(rev)}/{subpath}, mirroring Blob.jsx. Extends the #29 breadcrumb-head regression test with a Tree rev case.

Proof: node --test web/test/unit/*.test.js 387/387 green (with web/node_modules present); headless-Chrome CDP drive of a scratch server on a seeded nested repo: tree docs/go shows root->/u/crumbtest, docs->/u/crumbtest/tree/main/docs, current go strong; click-through lands on /tree/main/docs with rows [go]; blob crumbs unchanged; zero console errors. No new deps; styling untouched (dark+light unaffected). No doc change needed: docs/go/12_web_ui.md already states the breadcrumb carries ref+path.

Tree Breadcrumb built intermediate hrefs as `/{full}/tree/{subpath}`, dropping the display ref, so nested crumbs (e.g. docs in docs/go) missed the branch while root worked. Now passes `rev={t().ref}` and renders `/{full}/tree/{shortRef(rev)}/{subpath}`, mirroring Blob.jsx. Extends the #29 breadcrumb-head regression test with a Tree rev case. Proof: `node --test web/test/unit/*.test.js` 387/387 green (with web/node_modules present); headless-Chrome CDP drive of a scratch server on a seeded nested repo: tree docs/go shows root->/u/crumbtest, docs->/u/crumbtest/tree/main/docs, current go strong; click-through lands on /tree/main/docs with rows [go]; blob crumbs unchanged; zero console errors. No new deps; styling untouched (dark+light unaffected). No doc change needed: docs/go/12_web_ui.md already states the breadcrumb carries ref+path.

crueber added 1 commit

2026-09-08 12:30:13 +00:00

Fix #189 : Tree breadcrumb segment links carry the ref c0358f3d8b

Tree Breadcrumb built intermediate hrefs as /{full}/tree/{subpath},
dropping the display ref, so nested crumbs (e.g. docs in docs/go)
missed the branch and did not resolve. Pass rev={t().ref} at the
call site and render hrefs as /{full}/tree/{shortRef(rev)}/{subpath},
mirroring Blob.jsx. Extends the #29 breadcrumb-head regression test.

crueber referenced this pull request

2026-09-08 12:30:19 +00:00

Only some code tab breadcrumbs work. #189

crueber referenced this pull request

2026-09-08 12:33:14 +00:00

Only some code tab breadcrumbs work. #189

crueber merged commit cd0f3efd1c into main

2026-09-08 12:33:36 +00:00

crueber referenced this pull request

2026-09-08 12:33:37 +00:00

Only some code tab breadcrumbs work. #189

crueber referenced this pull request from a commit