Fixed by #193 (branch fix/issue-190): design.md → DESIGN.md and README.md → README.MD, with all root-file references moved in the same change. Ready for review — not merging per instructions.

crueber commented

2026-09-08 12:41:25 +00:00

Author

Owner

Review of PR #193 (fix/issue-190, commit 988c837) — verified in scratch worktree /tmp/pr193 (removed afterward); main worktree untouched (still only untracked .opencode/).

RENAMES (pure git-mv):

README.md -> README.MD: similarity R100, zero content change. OK.
design.md -> DESIGN.md: similarity R99, sole content delta is the self-title DESIGN.md:1 ('# DESIGN.md ...'); body untouched. As expected.

REFERENCES (own case-sensitive greps on the branch):

'design.md': zero hits remaining. OK.
'README.md' remaining hits all verified non-root, rightly unchanged: sample user-repo snippets (README.MD:32, web/src/pages/Landing.jsx:121, docs/go/16_packaging.md:496), headless fixtures for user files (web/test/unit/doctabs.test.js, sdk-surface.test.js:35-36, repo-tabs.test.js:16, internal/api/*_test.go, bind_wal_test.go), docs/features/02_issues.md:4, 03_pull_requests.md:5, 04_code_review.md:4, 06_notifications.md:4 + 09_rollout.md:3 (all docs/features/README.md, relative links), 02_issues.md:187 '(README law' = features-README P-law, and DEVIATIONS.md:3 / AGENTS.md:46 'docs/go/README.md' (different file). No missed live root reference.

.dockerignore (case-sensitive): lines 9-10 now read DESIGN.md / README.MD, exactly matching the renamed files on disk (old names confirmed absent). Still correct; no stale pattern.

doc-tabs: web/src/lib/doctabs.js:9 MD_RE and :12 README_RE are both /i case-insensitive, so README.MD matches; covered by web/test/unit/doctabs.test.js:32 ('Readme.MD', 'README.MARKDOWN'). Root rename cannot hide the tab.

LOGIC: diff name-only = .dockerignore, AGENTS.md, DESIGN.md, README.MD, docs/go/01_overview.md, 11_config_cli.md, 12_web_ui.md, 16_packaging.md — renames + prose only, no .go/.js/.jsx. Demo snippets (Landing.jsx:121, README.MD:32, 16_packaging.md:496) stay lowercase correctly: they create files in a sample user repo, not this repo.

LAW 12: docs and renames move in the same change; no new Decisions entry needed (filename case only, no spec/behavior deviation).

TESTS (scratch worktree; node_modules symlinked from main worktree read-only, no installs):

node --test web/test/unit/*.test.js: 387 pass / 0 fail.
vite build: ok (125 modules, 1.69s).
esbuild SDK bundle: ok (27.8kb).
No browser drive (reasoning + tests only): change is renames + prose, nothing browser-facing; doc-tabs regex verified by reading + unit tests.

MERGE RECOMMENDATION: ready to merge.

Review of PR #193 (fix/issue-190, commit 988c837) — verified in scratch worktree /tmp/pr193 (removed afterward); main worktree untouched (still only untracked .opencode/). RENAMES (pure git-mv): - README.md -> README.MD: similarity R100, zero content change. OK. - design.md -> DESIGN.md: similarity R99, sole content delta is the self-title DESIGN.md:1 ('# DESIGN.md ...'); body untouched. As expected. REFERENCES (own case-sensitive greps on the branch): - 'design.md': zero hits remaining. OK. - 'README.md' remaining hits all verified non-root, rightly unchanged: sample user-repo snippets (README.MD:32, web/src/pages/Landing.jsx:121, docs/go/16_packaging.md:496), headless fixtures for user files (web/test/unit/doctabs.test.js, sdk-surface.test.js:35-36, repo-tabs.test.js:16, internal/api/*_test.go, bind_wal_test.go), docs/features/02_issues.md:4, 03_pull_requests.md:5, 04_code_review.md:4, 06_notifications.md:4 + 09_rollout.md:3 (all docs/features/README.md, relative links), 02_issues.md:187 '(README law' = features-README P-law, and DEVIATIONS.md:3 / AGENTS.md:46 'docs/go/README.md' (different file). No missed live root reference. .dockerignore (case-sensitive): lines 9-10 now read DESIGN.md / README.MD, exactly matching the renamed files on disk (old names confirmed absent). Still correct; no stale pattern. doc-tabs: web/src/lib/doctabs.js:9 MD_RE and :12 README_RE are both /i case-insensitive, so README.MD matches; covered by web/test/unit/doctabs.test.js:32 ('Readme.MD', 'README.MARKDOWN'). Root rename cannot hide the tab. LOGIC: diff name-only = .dockerignore, AGENTS.md, DESIGN.md, README.MD, docs/go/01_overview.md, 11_config_cli.md, 12_web_ui.md, 16_packaging.md — renames + prose only, no .go/.js/.jsx. Demo snippets (Landing.jsx:121, README.MD:32, 16_packaging.md:496) stay lowercase correctly: they create files in a sample user repo, not this repo. LAW 12: docs and renames move in the same change; no new Decisions entry needed (filename case only, no spec/behavior deviation). TESTS (scratch worktree; node_modules symlinked from main worktree read-only, no installs): - node --test web/test/unit/*.test.js: 387 pass / 0 fail. - vite build: ok (125 modules, 1.69s). - esbuild SDK bundle: ok (27.8kb). - No browser drive (reasoning + tests only): change is renames + prose, nothing browser-facing; doc-tabs regex verified by reading + unit tests. MERGE RECOMMENDATION: ready to merge.

crueber closed this issue

2026-09-08 12:41:49 +00:00

crueber commented

2026-09-08 12:41:49 +00:00

Author

Owner

Fixed by PR #193 (review: pure renames, all live references updated, dockerignore case-correct; 387/387), merged. Closing.

crueber referenced this issue from a commit

2026-09-08 12:41:50 +00:00

Merge pull request 'Fix #190: uppercase root markdown names' (#193) from fix/issue-190 into main

crueber added the

git storage