crueber/walhub
Watch
1
0
Fork
You've already forked walhub
 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity

Fix #332: pulls default open-only #341

Merged
crueber merged 2 commits from fix/issue-332 into main 2026-09-11 17:48:24 +00:00
Conversation 0 Commits 2 Files changed 4 +113 -5
crueber commented 2026-09-11 17:40:10 +00:00
Owner
Copy link

Mirrors the #323 issues resolution for the pulls list: bare /:o/:r/pulls visits resolve to open-only (wire state=open, open tab highlighted), explicit both is ?state=all via a third tab (sent wire-omitted, since the endpoint accepts open|closed|absent only), legacy empty ?state= still reads as both. Backend untouched — ListPRs empty-state=both (service.go:782-784) is now the relied-upon contract for the wire-omitted both-choice; Pulls.jsx is the sole pulls.list consumer. Resolver in web/src/lib/pullState.js + web/test/unit/pull-state.test.js; decision in 03 Decisions (law 12). Tests: node --test 651/651 green, vite+esbuild builds green, go vet clean, go test -race internal/pulls ok, coverage 97.7% (>=95%). Fixes #332.

Mirrors the #323 issues resolution for the pulls list: bare /:o/:r/pulls visits resolve to open-only (wire state=open, open tab highlighted), explicit both is ?state=all via a third tab (sent wire-omitted, since the endpoint accepts open|closed|absent only), legacy empty ?state= still reads as both. Backend untouched — ListPRs empty-state=both (service.go:782-784) is now the relied-upon contract for the wire-omitted both-choice; Pulls.jsx is the sole pulls.list consumer. Resolver in web/src/lib/pullState.js + web/test/unit/pull-state.test.js; decision in 03 Decisions (law 12). Tests: node --test 651/651 green, vite+esbuild builds green, go vet clean, go test -race internal/pulls ok, coverage 97.7% (>=95%). Fixes #332.
Mirror the #323 issues resolution: bare /:o/:r/pulls visits resolve to open-only (wire state=open), explicit both is ?state=all (third tab, wire-omitted), legacy empty ?state= still reads as both. Backend untouched (ListPRs absent=both is the relied-upon contract). Resolver in web/src/lib/pullState.js with node --test cover; decision appended to 03 Decisions (law 12).
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
actions

   
bug
Something is not working

  
cli

   
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
fork

   
forum

   
git storage

   
help wanted
Need some help

  
insights

   
invalid
Something is wrong

  
issues

   
moderation

   
oidc

   
ownership transfer

   
packages

   
pr/merge protection rules

   
projects

   
pull requests

   
question
More information is needed

  
releases

   
sponsorships

   
tags

   
webhooks

   
wiki

   
wontfix
This won't be fixed

No labels
actions
bug
cli
duplicate
enhancement
fork
forum
git storage
help wanted
insights
invalid
issues
moderation
oidc
ownership transfer
packages
pr/merge protection rules
projects
pull requests
question
releases
sponsorships
tags
webhooks
wiki
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
crueber/walhub!341
No description provided.