Fix #424: fork operation #431

Merged

crueber merged 2 commits from fix/issue-424 into main

2026-09-13 03:24:56 +00:00

crueber commented

2026-09-13 03:09:07 +00:00

Owner

Implements docs/features/03 §7 (the unimplemented fork spec) plus the merge-durability fix the acceptance path requires.

Fork core (internal/pulls): ForkExecutor ShareExecutor wired at composition (verbatim pack set, fresh refs snapshot + branch override, checkpoint, child manifest.pb Create min_seq=seq+1); ForkInput gains visibility/branch/description with server-honored semantics; sync 409 fail-fast on taken names; #346 target admission; child access bootstrap; fork.json Root + listable GET forks index.

GC (internal/maintain): fork-network rule — superseded packs survive while any live fork-network manifest references them (transitive, probe-capped, fail-closed on corrupt index).

Reads (internal/wal): ancestor fallback for pack content (repo-prefixed keys cannot serve verbatim references — law-12 amendment in 03 Decisions); failure-path only, byte-identical non-fork behavior.

Merge durability (required by acceptance 3+7): merge/update-branch commits upload objects atomically (PackTip + RefPack seam, 04_git.md argv) — a merged parent was unclonable (upload-pack: not our ref), which no fork could survive.

UI/API: Fork button + Fork.jsx + Forks.jsx, summary fork_parent/forks + ETag, SDK, Apidocs.

Proof: pulls/api/maintain/wal/cmd green (race + >=95% cover), sim green, e2e full chain 7.5s (fork phase 91ms), node 893 pass (2 pre-existing smoke fails per #422 note), vite green. No new deps.

Implements docs/features/03 §7 (the unimplemented fork spec) plus the merge-durability fix the acceptance path requires. Fork core (internal/pulls): ForkExecutor ShareExecutor wired at composition (verbatim pack set, fresh refs snapshot + branch override, checkpoint, child manifest.pb Create min_seq=seq+1); ForkInput gains visibility/branch/description with server-honored semantics; sync 409 fail-fast on taken names; #346 target admission; child access bootstrap; fork.json Root + listable GET forks index. GC (internal/maintain): fork-network rule — superseded packs survive while any live fork-network manifest references them (transitive, probe-capped, fail-closed on corrupt index). Reads (internal/wal): ancestor fallback for pack content (repo-prefixed keys cannot serve verbatim references — law-12 amendment in 03 Decisions); failure-path only, byte-identical non-fork behavior. Merge durability (required by acceptance 3+7): merge/update-branch commits upload objects atomically (PackTip + RefPack seam, 04_git.md argv) — a merged parent was unclonable (upload-pack: not our ref), which no fork could survive. UI/API: Fork button + Fork.jsx + Forks.jsx, summary fork_parent/forks + ETag, SDK, Apidocs. Proof: pulls/api/maintain/wal/cmd green (race + >=95% cover), sim green, e2e full chain 7.5s (fork phase 91ms), node 893 pass (2 pre-existing smoke fails per #422 note), vite green. No new deps.

crueber added 1 commit

2026-09-13 03:09:10 +00:00

Fix #424 : fork operation (ForkExecutor share + GC rule + fork UI) 7a9695140b

Implements docs/features/03 §7 (unimplemented spec): ShareExecutor copies
the parent manifest (verbatim pack set, fresh refs snapshot + checkpoint,
child manifest.pb Create min_seq=seq+1); fork-network GC consults
children's manifests before pack deletion; fork reads fall back across
the ancestry (repo-prefixed keys cannot serve verbatim references
otherwise — law-12 amendment, see 03 Decisions).

Also required by the acceptance path: merge/update-branch commits now
upload their objects atomically with the ref (PackTip + RefPack seam) —
a merged parent was unclonable (upload-pack: not our ref), which no fork
could survive.

UI: Fork button + Fork.jsx form + Forks.jsx list; summary fork_parent/
forks projection with ETag; SDK forks.create/list. Docs: 03 §5/§7/§8 +
Decisions, 04_git.md PackTip argv. No new deps.

crueber referenced this pull request

2026-09-13 03:09:15 +00:00

Fork button next to Clone on the code page + fork-creation page (owner/name/visibility/branch/description) and a completed server-side fork operation #424

crueber referenced this pull request from a commit

2026-09-13 03:21:24 +00:00

Review #431: fail-closed fork-network GC (transient/child-index/corrupt/cap abort)

crueber added 1 commit

2026-09-13 03:21:25 +00:00

Review #431 : fail-closed fork-network GC (transient/child-index/corrupt/cap abort) 1d90aff3f1

Transient child-manifest errors, child-index errors, corrupt child
manifests, and probe-cap exhaustion with unvisited children remaining
now abort the sweep with nothing deleted (docs/features/03 §7 fail-closed
rule); only a deleted child (manifest 404) skips its subtree. Four new
regression tests; 03 Decisions records the rule.

crueber referenced this pull request

2026-09-13 03:21:55 +00:00

Fork button next to Clone on the code page + fork-creation page (owner/name/visibility/branch/description) and a completed server-side fork operation #424

crueber referenced this pull request

2026-09-13 03:24:31 +00:00

Fork post-share failure strands target name (needs manual bucket cleanup) #432

crueber merged commit a638c04568 into main

2026-09-13 03:24:56 +00:00

crueber referenced this pull request

2026-09-13 03:25:02 +00:00

Fork button next to Clone on the code page + fork-creation page (owner/name/visibility/branch/description) and a completed server-side fork operation #424

crueber referenced this pull request from a commit