Draft PRs are unreachable: Draft is never set, so the draft merge-blocker and Draft phrase are dead #613

New issue

Closed

opened 2026-09-15 23:05:26 +00:00 by crueber · 1 comment

crueber commented

2026-09-15 23:05:26 +00:00

Owner

Evidence (live field test + static read)

internal/pulls/service.go:422 hardcodes Draft: false at PR creation; no UpdatePR field, route, SDK method, or UI control ever sets Draft=true (verified by repo-wide grep — the only Draft=true write in non-test code is releases).
The merge machine still handles draft (mergeState draft → button disabled, tooltip draft PRs cannot merge; mergeabilityDisplay maps draft → Draft pull request) and the server presumably refuses draft merges — but no draft PR can ever exist through UI or API, so the blocked-draft case in #600 cannot be exercised and the Draft phrase is unreachable.

What's requested (user's call)

Either (a) implement draft PRs (open-as-draft / mark-ready transitions, UI + API + docs), or (b) remove the dead draft handling (machine branch, tooltip, phrase mapping, and any server draft gate) so untestable states don't linger. Recommend (a) only if draft workflow is wanted for v1; otherwise (b) keeps the machine honest. Note the choice.

Acceptance criteria

Either draft PRs can be created/flipped through UI+API with tests, or no draft-specific merge/UI code remains (grep Draft in pulls/MergeBox/pull-state.js comes back empty outside history).

## Evidence (live field test + static read) - internal/pulls/service.go:422 hardcodes Draft: false at PR creation; no UpdatePR field, route, SDK method, or UI control ever sets Draft=true (verified by repo-wide grep — the only Draft=true write in non-test code is releases). - The merge machine still handles draft (mergeState draft → button disabled, tooltip draft PRs cannot merge; mergeabilityDisplay maps draft → Draft pull request) and the server presumably refuses draft merges — but no draft PR can ever exist through UI or API, so the blocked-draft case in #600 cannot be exercised and the Draft phrase is unreachable. ## What's requested (user's call) Either (a) implement draft PRs (open-as-draft / mark-ready transitions, UI + API + docs), or (b) remove the dead draft handling (machine branch, tooltip, phrase mapping, and any server draft gate) so untestable states don't linger. Recommend (a) only if draft workflow is wanted for v1; otherwise (b) keeps the machine honest. Note the choice. ## Acceptance criteria - [ ] Either draft PRs can be created/flipped through UI+API with tests, or no draft-specific merge/UI code remains (grep Draft in pulls/MergeBox/pull-state.js comes back empty outside history).

crueber added this to the v1 milestone

2026-09-15 23:05:26 +00:00

crueber added the

bug

issues

pull requests

labels

2026-09-15 23:05:26 +00:00

crueber referenced this issue

2026-09-15 23:05:34 +00:00

Exploration: full field test of the PR UI (blocked merges, all merge strategies, commits land in repo) #600

crueber referenced this issue from a commit

2026-09-15 23:38:53 +00:00

Implement draft PRs: open-as-draft / mark-ready transitions (Forgejo #613, option a)

crueber referenced this issue from a pull request that will close it,

2026-09-15 23:38:58 +00:00

Draft PRs: open-as-draft / mark-ready transitions (fixes #613) #616

crueber referenced this issue from a commit

2026-09-15 23:45:04 +00:00

Merge pull request 'Draft PRs: open-as-draft / mark-ready transitions (fixes #613)' (#616) from fix/issue-613 into main

crueber closed this issue

2026-09-15 23:45:04 +00:00

crueber commented

2026-09-15 23:45:05 +00:00

Author

Owner

Implemented (option a) by #616 (merged): open-as-draft + mark-ready/convert-to-draft (author-or-triage, draft_changed events + fan-out, merged-terminal 409); merge refuses drafts pre-publish; PullNew checkbox + role-gated toggle + Draft badge; SDK draft key; docs amended. Verified: pulls 96.1% cover, -race green, 1590 web unit green (smoke excluded, pre-existing), vite/esbuild green, independent review APPROVE. Note: TestGetPRHeadDrift flake reproduced on clean main too — filing separately as pre-existing.

crueber referenced this issue

2026-09-15 23:45:13 +00:00

Flaky TestGetPRHeadDrift (stamp-without-stream), pre-existing on main #617

crueber referenced this issue

2026-09-28 18:55:18 +00:00

README v1: mark pulls + releases done (checkboxes lag reality) #633