Release asset upload uses hidden-in-label file input with no keyboard focus passthrough #621
Labels
No labels
actions
bug
cli
duplicate
enhancement
fork
forum
git storage
help wanted
insights
invalid
issues
moderation
oidc
ownership transfer
packages
pr/merge protection rules
projects
pull requests
question
releases
sponsorships
tags
webhooks
wiki
wontfix
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
crueber/walhub#621
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Follow-up candidate flagged by the #619 review (PR #620): web/src/pages/Release.jsx asset upload uses the same hidden-in-label file-input pattern that #619 just fixed on the profile sidebar — display:none removes the input from the Tab order with no focus-visible ring passthrough. Apply the same peer sr-only + focus ring treatment (or the #619 idiom verbatim). Out of scope for #619 (sibling raw inputs explicitly excluded there).
Fixed by #622 (merged): release asset upload restructured to the #619 idiom verbatim (peer sr-only input + #533 focus ring); label/upload/disabled/busy semantics byte-identical, drag-drop untouched. Verified: new test 4/4 (fail pre-fix), 1601 unit green (smoke excluded, pre-existing), vite/esbuild green, independent review APPROVE.