Release asset upload uses hidden-in-label file input with no keyboard focus passthrough #621

Closed
opened 2026-09-16 11:44:51 +00:00 by crueber · 1 comment
Owner

Follow-up candidate flagged by the #619 review (PR #620): web/src/pages/Release.jsx asset upload uses the same hidden-in-label file-input pattern that #619 just fixed on the profile sidebar — display:none removes the input from the Tab order with no focus-visible ring passthrough. Apply the same peer sr-only + focus ring treatment (or the #619 idiom verbatim). Out of scope for #619 (sibling raw inputs explicitly excluded there).

Follow-up candidate flagged by the #619 review (PR #620): web/src/pages/Release.jsx asset upload uses the same hidden-in-label file-input pattern that #619 just fixed on the profile sidebar — display:none removes the input from the Tab order with no focus-visible ring passthrough. Apply the same peer sr-only + focus ring treatment (or the #619 idiom verbatim). Out of scope for #619 (sibling raw inputs explicitly excluded there).
crueber added this to the v1 milestone 2026-09-16 11:44:51 +00:00
Author
Owner

Fixed by #622 (merged): release asset upload restructured to the #619 idiom verbatim (peer sr-only input + #533 focus ring); label/upload/disabled/busy semantics byte-identical, drag-drop untouched. Verified: new test 4/4 (fail pre-fix), 1601 unit green (smoke excluded, pre-existing), vite/esbuild green, independent review APPROVE.

Fixed by #622 (merged): release asset upload restructured to the #619 idiom verbatim (peer sr-only input + #533 focus ring); label/upload/disabled/busy semantics byte-identical, drag-drop untouched. Verified: new test 4/4 (fail pre-fix), 1601 unit green (smoke excluded, pre-existing), vite/esbuild green, independent review APPROVE.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
crueber/walhub#621
No description provided.