Fix #165: remove server-side TLS #167

Merged

crueber merged 2 commits from fix/issue-165 into main

2026-09-05 23:30:31 +00:00

crueber commented

2026-09-05 23:26:04 +00:00

Owner

Config fails closed with a reverse-proxy pointer: residual server.tls.* in TOML rejected at load; WALHUB__SERVER__TLS__* env override fatal (deliberate exception to the soft unknown-key rule).
Setup UI: TLS fields removed from schema (server reflection + web FIELDS); stale values surface as unknown-key errors.
Honors X-Forwarded-Proto when building absolute URLs (closes the 12_web_ui.md follow-up, no separate issue); Caddy/nginx minimal snippets in 16_packaging.md §3.4.
x/crypto stays (SSH transport), x/net stays (h2c) — import budget unchanged, removals only.
Docs: Decisions entries in 06/11/16/01 + DEVIATIONS.md D-HTTP-4; 10.4 startup renumbered.

Tests: go vet clean; go test -race green on config/server/api/cmd; coverage 95.5% on config/server/api; node --test 325/325; e2e green; live smoke (plain HTTP, forwarded-proto https URLs, ca.pem 404, no tls keys in setup schema).

Fixes #165. Do NOT merge — review requested.

Removes server-side TLS (files/self_signed modes, cert/key loading, self-signed generation, TLS listener wrap, /services/public/ca.pem, setup.json ca_url/trust). Server listens plain HTTP, h2c retained. - Config fails closed with a reverse-proxy pointer: residual server.tls.* in TOML rejected at load; WALHUB__SERVER__TLS__* env override fatal (deliberate exception to the soft unknown-key rule). - Setup UI: TLS fields removed from schema (server reflection + web FIELDS); stale values surface as unknown-key errors. - Honors X-Forwarded-Proto when building absolute URLs (closes the 12_web_ui.md follow-up, no separate issue); Caddy/nginx minimal snippets in 16_packaging.md §3.4. - x/crypto stays (SSH transport), x/net stays (h2c) — import budget unchanged, removals only. - Docs: Decisions entries in 06/11/16/01 + DEVIATIONS.md D-HTTP-4; 10.4 startup renumbered. Tests: go vet clean; go test -race green on config/server/api/cmd; coverage 95.5% on config/server/api; node --test 325/325; e2e green; live smoke (plain HTTP, forwarded-proto https URLs, ca.pem 404, no tls keys in setup schema). Fixes #165. Do NOT merge — review requested.

crueber added 1 commit

2026-09-05 23:26:05 +00:00

Fix #165 : remove server-side TLS; terminate at the reverse proxy c61c4e9935

Removes files/self_signed modes, cert/key loading, self-signed
generation, the TLS listener wrap, /services/public/ca.pem, and the
setup.json ca_url/trust fields. Server listens plain HTTP (h2c
retained via x/net; x/crypto stays for the SSH transport).

Config fails closed with a reverse-proxy pointer: residual
server.tls.* in a TOML file is rejected at load; a
WALHUB__SERVER__TLS__* env override is fatal (deliberate exception
to the soft unknown-key rule). Setup UI schema (reflection +
FIELDS) drops the TLS fields; client flags stale values unknown-key.

Honors X-Forwarded-Proto when building absolute URLs (requestScheme
in server + api; display only), closing the 12_web_ui.md follow-up;
minimal Caddy/nginx snippets in 16_packaging.md §3.4.

Docs: Decisions entries in 06 (D-HTTP-4), 11, 16, 01;
DEVIATIONS.md D-DEP-3/D-HTTP-4; 10.4 startup renumbered 1-7.

crueber referenced this pull request

2026-09-05 23:26:09 +00:00

Remove server-side TLS; terminate at the reverse proxy #165

crueber referenced this pull request from a commit

2026-09-05 23:29:41 +00:00

Review #167: drop duplicated D-DEP-3 rationale line left by the TLS-removal edit

crueber added 1 commit

2026-09-05 23:29:41 +00:00