Fix #180: deterministic merge-gate tests

crueber commented

2026-09-06 18:09:44 +00:00

Owner

Test-only fix for #180. TestMergeConsultsReviewGate/deny pinned the transient running snapshot (StartMerge snapshots after spawning the worker; a descheduled test goroutine let the fast-denying fake gate run to terminal error first). fakeReviewGate/fakeChecksGate now block on test-owned entered/release channels: StartMerge -> deterministically running -> awaitGate -> release -> terminal assertions unchanged (error, narration, gate-once, no publish, not merged). Same treatment for the sister patterns: TestMergeConsultsChecksGate/deny and TestMergeStrategies (blocking allow review gate + gate-once pin). No production change. Verified: targeted -race -count=20 green, full internal/pulls -race green, coverage 97.7% (>=95%), gofmt/vet clean. Full ./internal/... -race green except pre-existing environmental e2e failure (fresh worktree lacks web/dist; unrelated).

crueber added 1 commit

2026-09-06 18:09:45 +00:00

Fix #180 : deterministic merge-gate tests via controllable fake gates b73f50e0e5

TestMergeConsultsReviewGate/deny pinned the transient running snapshot:
StartMerge returns entry.rec.snapshot() after spawning the worker, so a
descheduled test goroutine let the fast-denying fake gate run the worker
to terminal error before the snapshot. Same pattern in
TestMergeConsultsChecksGate/deny and TestMergeStrategies (merge_test.go:41).

fakeReviewGate/fakeChecksGate now block on test-owned channels (entered +
release): StartMerge -> deterministically running -> awaitGate proves the
worker reached the gate -> close(release) -> terminal assertions unchanged
(error, narration, gate-once, no publish, not merged). Test-only; no
production change. TestMergeStrategies uses a blocking allow review gate
plus a gate-once pin.

crueber referenced this pull request

2026-09-06 18:09:46 +00:00

Flaky merge-gate test asserts transient running state #180

crueber referenced this pull request from a commit

2026-09-06 18:12:33 +00:00

Review #181: guaranteed gate release via t.Cleanup

crueber added 1 commit

2026-09-06 18:12:34 +00:00

Review #181 : guaranteed gate release via t.Cleanup f472c3531b

On any pre-release test failure the merge worker would block forever on
<-release: its ctx is context.WithoutCancel (merge.go), so the ctx.Done
arm can never fire. t.Cleanup with a sync.Once release unblocks the
worker on every path. Test-only; no production change.

crueber referenced this pull request

2026-09-06 18:12:41 +00:00

Flaky merge-gate test asserts transient running state #180

crueber merged commit 808ba98ba7 into main

2026-09-06 18:13:12 +00:00

crueber referenced this pull request

2026-09-06 18:13:13 +00:00

Flaky merge-gate test asserts transient running state #180

crueber referenced this pull request from a commit

2026-09-06 18:13:14 +00:00

Merge pull request 'Fix #180: deterministic merge-gate tests' (#181) from fix/issue-180 into main

Rows
Columns

Fix #180: deterministic merge-gate tests #181