Fix #225: chronological timeline #226

Merged

crueber merged 2 commits from fix/issue-225 into main

2026-09-09 04:19:24 +00:00

crueber commented

2026-09-09 03:48:26 +00:00

Owner

Chronological thread timelines (oldest top → newest bottom) on issues AND PR conversations via the shared ThreadTimeline (02 §11, 08 §2).

ThreadTimeline sorts stable-by-seq at render; the event-window wire stays newest-first (02 §7 Decisions) — no API change, client-side adaptation only.
Issue page: Older-events button moved above the thread; cursor reads the unfiltered assembly tail (no overlap/dup); viewport pinned across prepends (anchorScrollTop); SSE refetches never autoscroll (documented scroll policy: never yank the reader).
PR conversations inherit with zero PR-side code — both surfaces consistent by construction.
New pure lib web/src/lib/thread-order.js + web/test/unit/thread-order.test.js (8 ordering tests).
Comment-only corrections where code said newest-last but meant newest-first (web/sdk/src/issues.js, internal/issues/http_test.go assertion text; assertion logic unchanged).
Decisions appended to docs/features/02, 03, 08 in the same change (law 12).

Tests: node --test full unit suite 438/438 green; Go TestGetIssueHTTP green; gofmt/vet clean; no new deps.
Browser verification is OPEN: no CDP/chrome runnable in this environment (:9222 down) — long-thread top-oldest/bottom-newest + load-older + live-append in both themes with zero console errors still needs a real-Chromium pass. Do NOT merge before that.

Chronological thread timelines (oldest top → newest bottom) on issues AND PR conversations via the shared ThreadTimeline (02 §11, 08 §2). - ThreadTimeline sorts stable-by-seq at render; the event-window wire stays newest-first (02 §7 Decisions) — no API change, client-side adaptation only. - Issue page: Older-events button moved above the thread; cursor reads the unfiltered assembly tail (no overlap/dup); viewport pinned across prepends (`anchorScrollTop`); SSE refetches never autoscroll (documented scroll policy: never yank the reader). - PR conversations inherit with zero PR-side code — both surfaces consistent by construction. - New pure lib `web/src/lib/thread-order.js` + `web/test/unit/thread-order.test.js` (8 ordering tests). - Comment-only corrections where code said newest-last but meant newest-first (`web/sdk/src/issues.js`, `internal/issues/http_test.go` assertion text; assertion logic unchanged). - Decisions appended to docs/features/02, 03, 08 in the same change (law 12). Tests: node --test full unit suite 438/438 green; Go TestGetIssueHTTP green; gofmt/vet clean; no new deps. Browser verification is OPEN: no CDP/chrome runnable in this environment (:9222 down) — long-thread top-oldest/bottom-newest + load-older + live-append in both themes with zero console errors still needs a real-Chromium pass. Do NOT merge before that.

crueber added 1 commit

2026-09-09 03:48:26 +00:00

Fix #225 : chronological thread timelines (02 §11, 08 §2) 2591103d48

ThreadTimeline sorts stable-by-seq at render (oldest top, newest
bottom); the event-window wire stays newest-first, no API change.
Issue page: Older-events button above the thread, viewport pinned
across prepends (anchorScrollTop), never autoscrolled on SSE
appends. PR conversations inherit via the shared component with no
PR-side code. Decisions appended to 02/03/08; ordering pinned by
web/test/unit/thread-order.test.js.

crueber referenced this pull request

2026-09-09 03:48:31 +00:00

Issue timeline should read oldest to newest #225

crueber referenced this pull request from a commit

2026-09-09 03:58:43 +00:00

Review #226: NaN-safe tiebreak in chronological() (08 Decisions)

crueber added 1 commit

2026-09-09 03:58:43 +00:00

Review #226 : NaN-safe tiebreak in chronological() (08 Decisions) b9e38571da

Both-missing-seq now falls to the index tiebreak explicitly instead of
returning NaN (sort coerces NaN to 0 — same result, but implicit).
Behavior identical on all real inputs; thread-order tests still 8/8.

crueber referenced this pull request

2026-09-09 03:58:52 +00:00

Issue timeline should read oldest to newest #225

crueber referenced this pull request

2026-09-09 04:17:55 +00:00

Issue timeline should read oldest to newest #225

crueber merged commit 67055c14f2 into main

2026-09-09 04:19:24 +00:00

crueber referenced this pull request

2026-09-09 04:19:26 +00:00

Issue timeline should read oldest to newest #225

crueber referenced this pull request from a commit