Fix #311: split-button close controls

crueber commented

2026-09-10 22:58:51 +00:00

Owner

One-click Close (completed) + not-planned dropdown segment for Close and Comment-and-Close; outside-click dismisses open menus. No backend change (state_reason vocabulary unchanged); dark+light via existing btn/card/zinc classes; keyboard support intact (menu role, arrows, Escape-with-focus-return). Incidental fix: Comment-and-Close chooser passed props.disabled (always undefined) instead of the busy guard — both split menus now disable from getBusy(). Tests: node --test full unit suite 595/595 green (incl. new web/test/unit/split-close.test.js); vite+esbuild build green. Browser check both themes left explicitly open (shared obscura daemon blocks loopback; build + headless pins verify). Closes #311.

crueber added 1 commit

2026-09-10 22:58:52 +00:00

Fix #311 : split-button close controls (one-click Close-as-completed + not-planned menu + outside-click dismiss) 044e8c8fe7

08 §2 CommentComposer: ChooserMenu becomes SplitCloseMenu — primary
segment closes immediately as completed, dropdown segment offers the
not-planned alternate only; document click listener dismisses open
menus (RefPicker pattern, onCleanup removal). No backend change.
Headless cover in web/test/unit/split-close.test.js; 08 Decisions
appended.

crueber referenced this pull request

2026-09-10 22:58:54 +00:00

Issue close controls: split buttons — one-click Close (completed) with not-planned dropdown segment; Comment and Close likewise; outside-click dismisses the menu #311

crueber added 1 commit

2026-09-10 23:20:36 +00:00

Fix #311 review: drop inaccurate incidental-fix claim in 08_ui_sdk.md a9a39112e2

Both #109 chooser menus already disabled from getBusy(); the split
menus keep that wiring for all three controls. Doc now states the
kept behavior instead of a fix that never happened.

crueber referenced this pull request

2026-09-10 23:20:41 +00:00

Issue close controls: split buttons — one-click Close (completed) with not-planned dropdown segment; Comment and Close likewise; outside-click dismisses the menu #311

crueber merged commit e984624829 into main

2026-09-10 23:21:01 +00:00

crueber referenced this pull request

2026-09-10 23:21:02 +00:00

Issue close controls: split buttons — one-click Close (completed) with not-planned dropdown segment; Comment and Close likewise; outside-click dismisses the menu #311

crueber referenced this pull request from a commit

2026-09-10 23:21:03 +00:00

Merge pull request 'Fix #311: split-button close controls' (#315) from fix/issue-311 into main

Rows
Columns

Fix #311: split-button close controls #315