crueber/walhub
Watch
1
0
Fork
You've already forked walhub
 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity

Fix #31: emoji reaction icons + per-comment summary #40

Merged
crueber merged 2 commits from fix/issue-31 into main 2026-09-04 17:04:41 +00:00
Conversation 0 Commits 2 Files changed 5 +158 -14
crueber commented 2026-09-04 17:02:36 +00:00
Owner
Copy link

Reaction picker buttons render unicode emoji glyphs (no new deps) with the wire words kept in aria-label/title; each opened/commented event renders its reaction_summary as an emoji+count chip row with toggle semantics; reaction_changed rows read e.g. reacted eyes on #0. Live update rides the existing reload()+SSE-invalidate path (verified in-browser). Decision appended to docs/features/02 Decisions. Tests: node --test 190 pass (incl. new reactions.test.js); real-browser dark+light with zero console errors. Known limitation: post-mutation refetch can lose a race against ccSWR stale cache serves on disk-starved hosts (follow-up with evidence to come).

Reaction picker buttons render unicode emoji glyphs (no new deps) with the wire words kept in aria-label/title; each opened/commented event renders its reaction_summary as an emoji+count chip row with toggle semantics; reaction_changed rows read e.g. reacted eyes on #0. Live update rides the existing reload()+SSE-invalidate path (verified in-browser). Decision appended to docs/features/02 Decisions. Tests: node --test 190 pass (incl. new reactions.test.js); real-browser dark+light with zero console errors. Known limitation: post-mutation refetch can lose a race against ccSWR stale cache serves on disk-starved hosts (follow-up with evidence to come).
Picker buttons render unicode glyphs (no new deps) with the wire words
kept in aria-label/title; each opened/commented event renders its
reaction_summary as an emoji+count chip row (toggle semantics);
reaction_changed rows read 'reacted eyes on #N' with glyph.
Decision appended to docs/features/02 Decisions.
<p> exposes no landmark/group semantics, so aria-label on it is
ignored by assistive tech; the actionsFor button row already uses
role=group — match it.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
actions

   
bug
Something is not working

  
cli

   
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
fork

   
forum

   
git storage

   
help wanted
Need some help

  
insights

   
invalid
Something is wrong

  
issues

   
moderation

   
oidc

   
ownership transfer

   
packages

   
pr/merge protection rules

   
projects

   
pull requests

   
question
More information is needed

  
releases

   
sponsorships

   
tags

   
webhooks

   
wiki

   
wontfix
This won't be fixed

No labels
actions
bug
cli
duplicate
enhancement
fork
forum
git storage
help wanted
insights
invalid
issues
moderation
oidc
ownership transfer
packages
pr/merge protection rules
projects
pull requests
question
releases
sponsorships
tags
webhooks
wiki
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
crueber/walhub!40
No description provided.