Fix #437: sidebar tabs + drop teaser #439

Merged
crueber merged 2 commits from fix/issue-437 into main 2026-09-13 13:20:13 +00:00
Owner

Supersedes the #435 strip-first placement. OwnerTabs becomes a vertical tab list first in the profile-layout right sidebar (ungated sibling above the gated #421 avatar asides — tabs for all viewers, both variants; org gets Profile | Repositories); all three views share one layout grid so tabs stay one click away. Active tab fills its row with the container selected background (zinc light+dark, aria-current kept) for a connected true-tab look. Deletes the leftover profile-view repository-count teaser; the tab count paragraph stays. Tests: new owner-tabs-sidebar-437.test.js (10 tests) replaces owner-tabs-top-435.test.js; 422/430/421/profile-header/403 pins rescoped. Full node --test: 810 total / 796 pass / 14 fail — the 14 are pre-existing on pristine origin/main (identical set); vite + esbuild green. Layout/markup only, no backend, no new deps. Law-12 decision in docs/go/12_web_ui.md FIXED entry. Fixes #437.

Supersedes the #435 strip-first placement. OwnerTabs becomes a vertical tab list first in the profile-layout right sidebar (ungated sibling above the gated #421 avatar asides — tabs for all viewers, both variants; org gets Profile | Repositories); all three views share one layout grid so tabs stay one click away. Active tab fills its row with the container selected background (zinc light+dark, aria-current kept) for a connected true-tab look. Deletes the leftover profile-view repository-count teaser; the tab count paragraph stays. Tests: new owner-tabs-sidebar-437.test.js (10 tests) replaces owner-tabs-top-435.test.js; 422/430/421/profile-header/403 pins rescoped. Full node --test: 810 total / 796 pass / 14 fail — the 14 are pre-existing on pristine origin/main (identical set); vite + esbuild green. Layout/markup only, no backend, no new deps. Law-12 decision in docs/go/12_web_ui.md FIXED entry. Fixes #437.
Supersedes the #435 strip-first placement: OwnerTabs renders first in
the profile-layout right sidebar (ungated sibling above the gated #421
avatar asides, so all viewers on both variants get tabs; org variant
gets Profile | Repositories); all three views share one layout grid so
tabs stay one click away. Active tab fills its row with the container
selected background (zinc, light+dark) for a connected true-tab look.
Deletes the leftover profile-view repository-count teaser; the tab's
own count paragraph stays. Replaces owner-tabs-top-435.test.js with
owner-tabs-sidebar-437.test.js; rescopes four stale pins to the profile
branch. Layout/markup only: no backend, no new deps. Docs: 12_web_ui.md
FIXED entry (law 12).
Reproduced head-to-head in scratch worktrees (node v26, symlinked
node_modules): branch 913 total / 911 pass / 2 fail vs pristine main
912 / 910 / 2 — the only failures are the live-server smoke subtests,
identical names before/after, zero PR-caused. The 810/796/14 line
does not reproduce from the branch tip.
Sign in to join this conversation.
No description provided.