crueber/walhub
Watch
1
0
Fork
You've already forked walhub
 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity

Fix #460: GC probe cap #471

Merged
crueber merged 1 commit from fix/issue-460 into main 2026-09-13 17:22:03 +00:00
Conversation 0 Commits 1 Files changed 4 +145 -19
crueber commented 2026-09-13 17:15:14 +00:00
Owner
Copy link

Child of #449 (F7). Raises maxForkNetworkProbes 64->512 (two probes/child, so ~256 direct children + transitive subtrees per pass); exhaustion still fails closed with nothing deleted. Refreshes stale one-level-per-pass comments (forknet.go, pulls model, features/03 §7 — the walk is breadth-first transitive in one pass; the cap, not depth, bounds it). Tests: TestForkNetworkGCWideFanout (40 children compact, measured cost pinned at exactly 81 GETs) + TestForkNetworkGCCapExceeded reworked to 300 children aborting safely. Full maintain suite -race green, coverage 95.5% (>=95% gate), vet/fmt clean. No new deps. No browser check needed (no browser-facing change). Residual bound stated in code + Decisions: fan-outs beyond ~256 children still defer; durable paged cursor is follow-up (needs bucket-side cursor state, a schema decision). Fixes #460.

Child of #449 (F7). Raises maxForkNetworkProbes 64->512 (two probes/child, so ~256 direct children + transitive subtrees per pass); exhaustion still fails closed with nothing deleted. Refreshes stale one-level-per-pass comments (forknet.go, pulls model, features/03 §7 — the walk is breadth-first transitive in one pass; the cap, not depth, bounds it). Tests: TestForkNetworkGCWideFanout (40 children compact, measured cost pinned at exactly 81 GETs) + TestForkNetworkGCCapExceeded reworked to 300 children aborting safely. Full maintain suite -race green, coverage 95.5% (>=95% gate), vet/fmt clean. No new deps. No browser check needed (no browser-facing change). Residual bound stated in code + Decisions: fan-outs beyond ~256 children still defer; durable paged cursor is follow-up (needs bucket-side cursor state, a schema decision). Fixes #460.
At two probes per child the 64 cap exhausted at ~32 direct children and
the sweep aborted every pass, so popular parents never compacted. The
walk is background maintain-path only (leased compact unit), so 512
exact-key GETs/pass is bounded law-6 cost. Fail-closed on exhaustion
preserved; fan-outs beyond ~256 children still defer (paged cursor is
documented follow-up). Tests: wide-fanout compacts with measured cost
(81 GETs), exhaustion aborts safely. Docs: features/03 Decisions.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
actions

   
bug
Something is not working

  
cli

   
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
fork

   
forum

   
git storage

   
help wanted
Need some help

  
insights

   
invalid
Something is wrong

  
issues

   
moderation

   
oidc

   
ownership transfer

   
packages

   
pr/merge protection rules

   
projects

   
pull requests

   
question
More information is needed

  
releases

   
sponsorships

   
tags

   
webhooks

   
wiki

   
wontfix
This won't be fixed

No labels
actions
bug
cli
duplicate
enhancement
fork
forum
git storage
help wanted
insights
invalid
issues
moderation
oidc
ownership transfer
packages
pr/merge protection rules
projects
pull requests
question
releases
sponsorships
tags
webhooks
wiki
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
crueber/walhub!471
No description provided.