Fix #484: milestone icons

crueber commented

2026-09-13 20:03:41 +00:00

Owner

Adds milestone-open/milestone-done to the #465 icons mechanism (embedded verbatim AS LABELED: open=16, done=24 — the issue body prose lists them swapped, files win per #465 precedent) and applies them state-mapped on all four surfaces with zero new requests: milestones-page open chip + closed rows, issues-list chip (cached-set state, truncating title span), repo strip option (a) — icon inside the Issues tab under /milestones (TABS/tabs.js/#319 badge/#274 scroll untouched; option (b) rejected: activeTab never returns a milestones id). Tests: new milestone-icons-484.test.js (9 tests); full node --test 944/929/15 vs pristine 935/920/15 (+9, zero PR-caused); vite build green with both paths in bundle. No new deps; law-12 decision in docs/go/12_web_ui.md. Browser proof open (shared-daemon loopback guard).

crueber added 1 commit

2026-09-13 20:03:42 +00:00

Fix #484 : milestone open/done icons state-mapped on 4 surfaces 3f8cabe8f3

Embeds milestone-open (16-unit) + milestone-done (24-unit) verbatim AS
LABELED into web/src/lib/icons.jsx (12_web_ui.md decision notes the
prose/files viewBox discrepancy). State-mapped, no new requests:
Milestones.jsx open chip + closed rows, Issues.jsx chip (cached-set
state, truncating title span), Repo.jsx strip option (a) — icon inside
the Issues tab under /milestones; TABS/tabs.js/#319/#274 untouched.

crueber referenced this pull request

2026-09-13 20:03:45 +00:00

Add milestone-open/milestone-done icons to the #465 icons mechanism; apply state-mapped on milestones page, issues list, and the repo tab strip #484

crueber referenced this pull request from a commit

2026-09-13 20:12:02 +00:00

Review #490: correct #484 entry test counts to measured 1064/1062/2

crueber added 1 commit

2026-09-13 20:12:02 +00:00

Review #490 : correct #484 entry test counts to measured 1064/1062/2 789e331604

The 944/929/15 numbers were stale: head-to-head shows pristine main at
1055/1053/2 (only the 2 live-server smoke subtests), PR at 1064/1062/2
(+9 net new, zero PR-caused).

crueber referenced this pull request

2026-09-13 20:12:26 +00:00

Add milestone-open/milestone-done icons to the #465 icons mechanism; apply state-mapped on milestones page, issues list, and the repo tab strip #484

crueber merged commit e351748926 into main

2026-09-13 20:13:09 +00:00

crueber referenced this pull request

2026-09-13 20:13:11 +00:00

Add milestone-open/milestone-done icons to the #465 icons mechanism; apply state-mapped on milestones page, issues list, and the repo tab strip #484

crueber referenced this pull request from a commit

2026-09-13 20:13:11 +00:00

Merge pull request 'Fix #484: milestone icons' (#490) from fix/issue-484 into main

Rows
Columns

Fix #484: milestone icons #490