Fix #546: diff line comments

crueber commented

2026-09-15 00:26:08 +00:00

Owner

Select line(s) in a PR diff to create inline comment threads, with a jump-to-comments index at the conversation top. Client-only: DiffTable comment-on-selection affordance → shared CommentComposer (no prompt); range anchors via new headless lib/review-anchor.js (single-line keeps stageLine shape, hash inputs byte-identical, pinned Go-twin vector untouched); Files-tab threads via pulls.threads.create; conversation ThreadIndex reflects placement truth incl. drifted. Tests: node --test 1278 total / 1277 pass / 1 pre-existing live-server smoke fail; vite+esbuild green; no new deps. Law-12 decisions in docs/features/04_code_review.md + docs/go/12_web_ui.md.

crueber added 1 commit

2026-09-15 00:26:09 +00:00

Fix #546 : diff line selection creates inline threads + jump-to-comments index 70d9ab11ad

Files-tab DiffBody gains a comment-on-selection affordance feeding the
shared CommentComposer; selection/range anchors build only through the
new headless lib/review-anchor.js (single-line keeps the stageLine
shape, hash inputs byte-identical — pinned Go-twin vector untouched).
Conversation replaces window.prompt with a draft composer, adds
Shift+click ranges and a ThreadIndex atop the conversation reflecting
placement truth. No backend, no new wire, no new deps.

crueber referenced this pull request

2026-09-15 00:26:12 +00:00

Select line(s) in a PR diff to create inline comment threads, with a jump-to-comments index at the conversation top #546

crueber referenced this pull request

2026-09-15 00:53:14 +00:00

Select line(s) in a PR diff to create inline comment threads, with a jump-to-comments index at the conversation top #546

crueber merged commit 1da914f62d into main

2026-09-15 00:54:25 +00:00

crueber referenced this pull request from a commit

2026-09-15 00:54:25 +00:00

Merge pull request 'Fix #546: diff line comments' (#551) from fix/issue-546 into main

crueber referenced this pull request

2026-09-15 00:54:26 +00:00

Select line(s) in a PR diff to create inline comment threads, with a jump-to-comments index at the conversation top #546

Rows
Columns

Fix #546: diff line comments #551