crueber/walhub
Watch
1
0
Fork
You've already forked walhub
 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity

Fix #547: merge strategy select #552

Merged
crueber merged 2 commits from fix/issue-547 into main 2026-09-15 01:34:25 +00:00
Conversation 0 Commits 2 Files changed 4 +141 -3
crueber commented 2026-09-15 01:13:04 +00:00
Owner
Copy link

Fixes #547 — the merge-strategy select on the PR page joins the system select idiom (styling/markup only; no backend, SDK, or API change; no new deps).

What changed (4 files):

  • web/src/components/MergeBox.jsx — strategy select takes the canonical .input w-full (same-page finish-review-verdict sibling, Pull.jsx:678); undefined field label becomes the #479 shape (label.grid.gap-1 mt-2 + text-sm font-medium span). The mt-2 button row below keeps its spacing — no overlap desktop or ~390px (sidebar stacks full-width, select fills it).
  • web/src/ui.css — base layer declares :root { color-scheme: light } + .dark { color-scheme: dark } so the NATIVE dropdown panel/option highlight follows the theme. Deliberately no appearance-none (OwnerNameRow precedent).
  • web/test/unit/merge-strategy-select-547.test.js — 6 headless tests (idiom/width/options, no-bare/no-field pins, #479 label + button-row order, base-layer color-scheme + intact-.input, full-src select sweep + named siblings, no-behavior-change).
  • docs/go/12_web_ui.md — law-12 decision (guideline §2 .input + §7 form shape by reference; no new pattern).

Deliberately untouched: legacy web/css/base.css:74 bare-select rule (unbundled — index.jsx imports ui.css only; sweep proves no bare selects remain); PullNew.jsx field labels (separate page, stays a noted follow-up per #545).

Acceptance: all 5 criteria pinned in the new test (incl. light+dark panel via color-scheme declarations in the built CSS bundle — verified color-scheme:light + color-scheme:dark in dist/assets/*.css).

Verification: node --test web/test/unit/*.test.js 1284 total / 1283 pass / 1 fail (the 1 failure is pre-existing on pristine origin/main: live-server smoke subtest, /setup 403 on the standing instance; +6 net new, zero PR-caused); vite build + esbuild green. Browser proof open (reasoned; shared-daemon loopback guard — no private daemon per workspace rules).

Fixes #547 — the merge-strategy select on the PR page joins the system select idiom (styling/markup only; no backend, SDK, or API change; no new deps). **What changed (4 files):** - `web/src/components/MergeBox.jsx` — strategy select takes the canonical `.input w-full` (same-page finish-review-verdict sibling, `Pull.jsx:678`); undefined `field` label becomes the #479 shape (`label.grid.gap-1 mt-2` + `text-sm font-medium` span). The `mt-2` button row below keeps its spacing — no overlap desktop or ~390px (sidebar stacks full-width, select fills it). - `web/src/ui.css` — base layer declares `:root { color-scheme: light }` + `.dark { color-scheme: dark }` so the NATIVE dropdown panel/option highlight follows the theme. Deliberately no `appearance-none` (OwnerNameRow precedent). - `web/test/unit/merge-strategy-select-547.test.js` — 6 headless tests (idiom/width/options, no-bare/no-field pins, #479 label + button-row order, base-layer color-scheme + intact-`.input`, full-src select sweep + named siblings, no-behavior-change). - `docs/go/12_web_ui.md` — law-12 decision (guideline §2 `.input` + §7 form shape by reference; no new pattern). **Deliberately untouched:** legacy `web/css/base.css:74` bare-select rule (unbundled — `index.jsx` imports ui.css only; sweep proves no bare selects remain); `PullNew.jsx` `field` labels (separate page, stays a noted follow-up per #545). **Acceptance:** all 5 criteria pinned in the new test (incl. light+dark panel via color-scheme declarations in the built CSS bundle — verified `color-scheme:light` + `color-scheme:dark` in `dist/assets/*.css`). **Verification:** `node --test web/test/unit/*.test.js` 1284 total / 1283 pass / 1 fail (the 1 failure is pre-existing on pristine origin/main: live-server smoke subtest, /setup 403 on the standing instance; +6 net new, zero PR-caused); `vite build` + `esbuild` green. Browser proof open (reasoned; shared-daemon loopback guard — no private daemon per workspace rules).
MergeBox strategy select takes .input w-full (same-page
finish-review-verdict sibling) inside the #479 label shape; ui.css
base layer declares color-scheme light/dark so the native dropdown
panel follows the theme. Decision appended to 12_web_ui.md.
The sibling-select regression test claimed 'no bare <select> anywhere
in web/src' but walk(SRC_DIR) only covered web/src/components; the
pages/ selects rode on named pins alone. Point SRC_DIR at web/src so
the assertion is true (68 jsx files, all selects .input — verified).
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
actions

   
bug
Something is not working

  
cli

   
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
fork

   
forum

   
git storage

   
help wanted
Need some help

  
insights

   
invalid
Something is wrong

  
issues

   
moderation

   
oidc

   
ownership transfer

   
packages

   
pr/merge protection rules

   
projects

   
pull requests

   
question
More information is needed

  
releases

   
sponsorships

   
tags

   
webhooks

   
wiki

   
wontfix
This won't be fixed

No labels
actions
bug
cli
duplicate
enhancement
fork
forum
git storage
help wanted
insights
invalid
issues
moderation
oidc
ownership transfer
packages
pr/merge protection rules
projects
pull requests
question
releases
sponsorships
tags
webhooks
wiki
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
crueber/walhub!552
No description provided.