FIXED (Forgejo #581) — thread card header drops the visible zero-padded tid #583

Merged

crueber merged 1 commit from fix/issue-581 into main

2026-09-15 16:34:46 +00:00

crueber commented

2026-09-15 16:33:12 +00:00

Owner

Removes the visible mono tid span from the ThreadCard header (Pull.jsx) — plain removal, no tooltip. Root id thread-, aria-label, flashTid mechanics, and anchorLabel index pills untouched. StagedCard keeps its meaningful anchorLabel header. New web/test/unit/thread-header-tid-581.test.js (6 tests); docs/go/12_web_ui.md amendment in the same commit. Full-minus-smoke green (1446 pass), vite build + esbuild + go vet clean.

Removes the visible mono tid span from the ThreadCard header (Pull.jsx) — plain removal, no tooltip. Root id thread-<tid>, aria-label, flashTid mechanics, and anchorLabel index pills untouched. StagedCard keeps its meaningful anchorLabel header. New web/test/unit/thread-header-tid-581.test.js (6 tests); docs/go/12_web_ui.md amendment in the same commit. Full-minus-smoke green (1446 pass), vite build + esbuild + go vet clean.

crueber added 1 commit

2026-09-15 16:33:12 +00:00

FIXED (Forgejo #581 ) — thread card header drops the visible zero-padded tid 9f7a4010d9

crueber commented

2026-09-15 16:34:35 +00:00

Author

Owner

APPROVE — PR #583 vs issue #581, independently verified in /tmp/walhub-581.

Acceptance (all hold):

No visible tid in header: the deleted span (Pull.jsx main:798) was the ONLY visible-tid render. Re-ran the sweep on the fix branch: remaining tid uses are the card-root id, aria-label, flashed() comparison, onFlash/onCollapse handlers, threads.comment/resolve/unresolve API args, ThreadComments tid prop, jump-target lookup (thread:${num}:${tid} data key + getElementById scroll), code comments, and ThreadIndex jumpToThread/clearFlashTid logic — no visible text. ThreadComments body renders only by/DateTime. Pills render anchorLabel (posted + staged), never a bare tid.
Root id thread- byte-identical (Fgrep main vs fix: same line), deep-link jumpToThread idiom untouched.
aria-label byte-identical; flash mechanics (flashed(), body-click onFlash, collapse onCollapse) byte-identical.
No test regresses: full-minus-smoke 1446 pass / 0 fail (matches PR claim). Smoke failure is environmental only — smoke.test.js found a stray 8080 listener returning 403 instead of skipping; unrelated to this JSX-only change. go vet clean.

Other checks:

StagedCard correctly untouched: header keeps label() (anchorLabel path:line, meaningful location, not an opaque id); diff touches only ThreadCard + its doc comment.
Law 12: 12_web_ui.md #581 amendment in the same commit. Law 1: no package.json/lock diff; new test pins runtime deps to exactly solid-js + @solidjs/router + marked + dompurify.
New tests fail pre-fix as required: with origin/main Pull.jsx restored, test 1 ('no visible tid span') fails on the present span while the other 5 pass — true negative, no false-positive guards.

No defects found — no fix commits made. Branch is clean on 9f7a401.

APPROVE — PR #583 vs issue #581, independently verified in /tmp/walhub-581. Acceptance (all hold): - No visible tid in header: the deleted span (Pull.jsx main:798) was the ONLY visible-tid render. Re-ran the sweep on the fix branch: remaining tid uses are the card-root id, aria-label, flashed() comparison, onFlash/onCollapse handlers, threads.comment/resolve/unresolve API args, ThreadComments tid prop, jump-target lookup (thread:${num}:${tid} data key + getElementById scroll), code comments, and ThreadIndex jumpToThread/clearFlashTid logic — no visible text. ThreadComments body renders only by/DateTime. Pills render anchorLabel (posted + staged), never a bare tid. - Root id thread-<tid> byte-identical (Fgrep main vs fix: same line), deep-link jumpToThread idiom untouched. - aria-label byte-identical; flash mechanics (flashed(), body-click onFlash, collapse onCollapse) byte-identical. - No test regresses: full-minus-smoke 1446 pass / 0 fail (matches PR claim). Smoke failure is environmental only — smoke.test.js found a stray 8080 listener returning 403 instead of skipping; unrelated to this JSX-only change. go vet clean. Other checks: - StagedCard correctly untouched: header keeps label() (anchorLabel path:line, meaningful location, not an opaque id); diff touches only ThreadCard + its doc comment. - Law 12: 12_web_ui.md #581 amendment in the same commit. Law 1: no package.json/lock diff; new test pins runtime deps to exactly solid-js + @solidjs/router + marked + dompurify. - New tests fail pre-fix as required: with origin/main Pull.jsx restored, test 1 ('no visible tid span') fails on the present span while the other 5 pass — true negative, no false-positive guards. No defects found — no fix commits made. Branch is clean on 9f7a401.

crueber merged commit c839c772e6 into main

2026-09-15 16:34:46 +00:00

crueber referenced this pull request from a commit

2026-09-15 16:34:47 +00:00

Merge pull request 'FIXED (Forgejo #581) — thread card header drops the visible zero-padded tid' (#583) from fix/issue-581 into main

crueber referenced this pull request

2026-09-15 16:34:47 +00:00

Remove the visible zero-padded thread id from the thread card header #581