Don't comment in the UI in the issue page #51

New issue

Closed

opened 2026-09-04 18:32:52 +00:00 by crueber · 3 comments

crueber commented

2026-09-04 18:32:52 +00:00

Owner

This image shows the comments in the UI:

Don't tell the user where the buttons are to perform the function. Expect them to know.

This image shows the comments in the UI: ![image](/attachments/ad55f58b-93ca-40a4-8310-d5bd058f6ca2) Don't tell the user where the buttons are to perform the function. Expect them to know.

image.png

18 KiB

crueber referenced this issue from a commit

2026-09-04 22:31:33 +00:00

Fix #51: drop issue-sidebar instructional text

crueber referenced this issue from a pull request that will close it,

2026-09-04 22:31:36 +00:00

Fix #51: drop sidebar instructional text #62

crueber commented

2026-09-04 22:31:40 +00:00

Author

Owner

Fix PR: #62 — drops the sidebar instructional text (STATE-card hint + LabelPicker empty-set pointer); values and affordances unchanged, no collapsing needed. Not merging; left for review.

Fix PR: https://git.packden.us/crueber/walhub/pulls/62 — drops the sidebar instructional text (STATE-card hint + LabelPicker empty-set pointer); values and affordances unchanged, no collapsing needed. Not merging; left for review.

crueber commented

2026-09-04 22:34:31 +00:00

Author

Owner

PR #62 review (branch fix/issue-51, commit e4eae81) — verified in scratch worktree /tmp/pr62 (since removed).

Both screenshot hints gone:

STATE 'close / reopen from the comment box' removed by this PR (web/src/pages/Issue.jsx:331-333 deleted). Confirmed absent on branch.
LABELS 'label / milestone edits live on their pages (triage)' — claim checks out: already removed by #45 (f6db534 replaced the static card with LabelPicker + chips). Absent on branch before and after this PR.

First-label path (LabelPicker fallback removal, LabelPicker.jsx:54): NOT stranded. Issues list has a visible Labels button (Issues.jsx:65) -> /{o}/{r}/labels route (index.jsx:78) -> Labels page with 'no labels yet' fallback + 'New label (triage)' create form. Removed pointer was text-only (no href), never the sole path. Non-blocking note: on an Issue page with zero labels a triage user now sees 'Labels / none' + empty picker with no on-page pointer; acceptable per #51's explicit drop-prose intent, a linked affordance could return later if desired.

No real affordances removed: picker rows/buttons/aria-pressed, applied-label chips with 'none' fallback, state badge value, assignees/milestone values all intact. No dep changes (package.json untouched). Dark+light unaffected (text/fallback removal only; chip classes unchanged). Doc update accurate: 08_ui_sdk.md now says STATE card keeps 'a read-only state badge only' with hint dropped per #51 — matches code.

Tests (scratch, same SHA): node --test web/test/unit/*.test.js 245/245 pass (initial 2 failures were missing node_modules in the fresh worktree, resolved via shared store — no code cause). vite build 108 modules + esbuild SDK bundle (26.8kb) both succeed. No browser drive (text-only change; noted per instructions).

MERGE RECOMMENDATION: ready to merge.

PR #62 review (branch fix/issue-51, commit e4eae81) — verified in scratch worktree /tmp/pr62 (since removed). Both screenshot hints gone: - STATE 'close / reopen from the comment box' removed by this PR (web/src/pages/Issue.jsx:331-333 deleted). Confirmed absent on branch. - LABELS 'label / milestone edits live on their pages (triage)' — claim checks out: already removed by #45 (f6db534 replaced the static card with LabelPicker + chips). Absent on branch before and after this PR. First-label path (LabelPicker fallback removal, LabelPicker.jsx:54): NOT stranded. Issues list has a visible Labels button (Issues.jsx:65) -> /{o}/{r}/labels route (index.jsx:78) -> Labels page with 'no labels yet' fallback + 'New label (triage)' create form. Removed pointer was text-only (no href), never the sole path. Non-blocking note: on an Issue page with zero labels a triage user now sees 'Labels / none' + empty picker with no on-page pointer; acceptable per #51's explicit drop-prose intent, a linked affordance could return later if desired. No real affordances removed: picker rows/buttons/aria-pressed, applied-label chips with 'none' fallback, state badge value, assignees/milestone values all intact. No dep changes (package.json untouched). Dark+light unaffected (text/fallback removal only; chip classes unchanged). Doc update accurate: 08_ui_sdk.md now says STATE card keeps 'a read-only state badge only' with hint dropped per #51 — matches code. Tests (scratch, same SHA): node --test web/test/unit/*.test.js 245/245 pass (initial 2 failures were missing node_modules in the fresh worktree, resolved via shared store — no code cause). vite build 108 modules + esbuild SDK bundle (26.8kb) both succeed. No browser drive (text-only change; noted per instructions). MERGE RECOMMENDATION: ready to merge.

crueber closed this issue

2026-09-04 22:34:45 +00:00

crueber commented

2026-09-04 22:34:46 +00:00

Author

Owner

Fixed by PR #62 (review clean; 245/245 node tests), merged. Closing.

crueber referenced this issue from a commit

2026-09-04 22:34:46 +00:00

Merge pull request 'Fix #51: drop sidebar instructional text' (#62) from fix/issue-51 into main

crueber referenced this issue from a commit

2026-09-05 05:48:31 +00:00